bugfix: fix DiagnosticId for AssertIsFalse & AssertIsTrue (#231)

* #160 fix DiagnosticId for AssertIsFalse & AssertIsTrue

* verify code-fixer diagnistics matches code analyzer

* fix AssertNotEqualCodeFix FixableDiagnosticIds

Author: Meir017

src/FluentAssertions.Analyzers.Tests/DiagnosticVerifier.cs

@@ -161,6 +161,8 @@ private static void VerifyFix(string language, DiagnosticAnalyzer analyzer, Code
                 }
             }
 
+            codeFixProvider.FixableDiagnosticIds.Should().BeEquivalentTo(analyzer.SupportedDiagnostics.Select(d => d.Id));
+
             //after applying all of the code fixes, compare the resulting string to the inputted one
             var actual = GetStringFromDocument(document);
             actual.Should().Be(newSource);

src/FluentAssertions.Analyzers/Tips/MsTest/AssertIsFalse.cs

@@ -36,7 +36,7 @@ public AssertIsFalseSyntaxVisitor() : base(new MemberValidator("IsFalse"))
     [ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(AssertIsFalseCodeFix)), Shared]
     public class AssertIsFalseCodeFix : MsTestAssertCodeFixProvider
     {
-        public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(CollectionShouldBeEmptyAnalyzer.DiagnosticId);
+        public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(AssertIsFalseAnalyzer.DiagnosticId);
 
         protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
             => RenameMethodAndReplaceWithSubjectShould(expression, "IsFalse", "BeFalse");

src/FluentAssertions.Analyzers/Tips/MsTest/AssertIsTrue.cs

@@ -36,7 +36,7 @@ public AssertIsTrueSyntaxVisitor() : base(new MemberValidator("IsTrue"))
     [ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(AssertIsTrueCodeFix)), Shared]
     public class AssertIsTrueCodeFix : MsTestAssertCodeFixProvider
     {
-        public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(CollectionShouldBeEmptyAnalyzer.DiagnosticId);
+        public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(AssertIsTrueAnalyzer.DiagnosticId);
 
         protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
             => RenameMethodAndReplaceWithSubjectShould(expression, "IsTrue", "BeTrue");

src/FluentAssertions.Analyzers/Tips/Xunit/AssertNotEqual.cs

@@ -77,7 +77,7 @@ public AssertObjectNotEqualSyntaxVisitor() : base(
 [ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(AssertNotEqualCodeFix)), Shared]
 public class AssertNotEqualCodeFix : XunitCodeFixProvider
 {
-    public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(AssertEqualAnalyzer.DiagnosticId);
+    public override ImmutableArray<string> FixableDiagnosticIds => ImmutableArray.Create(AssertNotEqualAnalyzer.DiagnosticId);
 
     protected override ExpressionSyntax GetNewExpression(
         ExpressionSyntax expression,