-
Notifications
You must be signed in to change notification settings - Fork 363
Open
Labels
P1high priority issues at the top of the work list, actively being worked on.high priority issues at the top of the work list, actively being worked on.infra
Description
As part of releasing DevTools, the release engineer is instructed to run dt serve to test the release: https://github.com/flutter/devtools/blob/master/tool/RELEASE_INSTRUCTIONS.md#3-test-the-release-pr
The dt serve command runs dart pub get inside the pkg/dds directory of the engineer's local Dart SDK.
However, the dart executable it uses is from the Flutter version specified in https://github.com/flutter/devtools/blob/b9d7fc1a4119b3d214a77939f9d75b0c0b25d36a/flutter-candidate.txt.
This means we are running an older dart executable inside the Dart SDK.
In the past this has worked, but with the introduction of perf_witness (which is currently using Dart SDK version 3.11.0-edge), running dt serve fails with:
[serve] running pub get for DDS in the local dart sdk
/Users/elliottbrooks/dev/dart-sdk/sdk/pkg/dds > /Users/elliottbrooks/dev/devtools/tool/flutter-sdk/bin/dart pub get
Resolving dependencies in `/Users/elliottbrooks/dev/dart-sdk/sdk`...
The current Dart SDK version is 3.11.0-285.0.dev.
Because perf_witness requires SDK version ^3.11.0-edge, version solving failed.
ProcessException: Failed with exit code: 1.
Metadata
Metadata
Assignees
Labels
P1high priority issues at the top of the work list, actively being worked on.high priority issues at the top of the work list, actively being worked on.infra