Skip to content

feat(menu): support descriptions in vertical menu #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
prudho wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat(menu): support descriptions in vertical menu #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion src/definitions/collections/menu.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@
border-radius: @borderRadius 0 0 @borderRadius;
}

.ui.menu > .item.vertical {
display: flex;
flex-direction: column-reverse;
}

/* Border */
.ui.menu .item::before {
position: absolute;
Expand Down Expand Up @@ -126,6 +131,26 @@
margin-bottom: 0;
}

.ui.menu > .item.vertical > .text {
margin-bottom: @verticalItemMargin;
}

/*-----------------
Item Description
-------------------*/

.ui.menu > .item > .description {
float: @itemDescriptionFloat;
margin: @itemDescriptionMargin;
color: @itemDescriptionColor;
}

.ui.menu > .item.vertical > .description {
margin: 0;
}



/*--------------
Icons
---------------*/
Expand Down Expand Up @@ -282,6 +307,10 @@
.ui.inverted.menu .search.dropdown.item > .text {
color: @invertedSelectionDropdownColor;
}

.ui.inverted.menu > .item > .description {
color: @invertedItemDescriptionColor;
}
}

& when (@variationMenuVertical) {
Expand Down Expand Up @@ -545,7 +574,7 @@ Floated Menu / Item
}

/*--- Item ---*/
.ui.vertical.menu .item {
.ui.vertical.menu .item:not(.vertical) {
display: block;
background: @verticalItemBackground;
border-top: none;
Expand Down
11 changes: 11 additions & 0 deletions src/themes/default/collections/menu.variables
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@
Elements
---------------*/

/* Description */
@itemDescriptionFloat: right;
@itemDescriptionMargin: 0 0 0 1em;
@itemDescriptionColor: @lightTextColor;

/* Vertical Item */
@verticalItemMargin: 0.25em;

/* Icon */
@iconFloat: none;
@iconMargin: 0 @relative5px 0 0;
Expand Down Expand Up @@ -427,6 +435,9 @@
@invertedColoredDividerBackground: @dividerBackground;
@invertedColoredActiveBackground: @strongTransparentBlack;

/* Inverted Vertical Description */
@invertedItemDescriptionColor: @invertedUnselectedTextColor;

/* Fixed */
@fixedPrecedingGridMargin: 2.75rem;

Expand Down