Skip to content

Conversation

@LaplaceSoda
Copy link

@LaplaceSoda LaplaceSoda commented Nov 27, 2025

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.14%. Comparing base (513ff50) to head (bb86830).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
- Coverage   25.14%   25.14%   -0.01%     
==========================================
  Files         570      570              
  Lines      234225   234225              
  Branches    41283    41285       +2     
==========================================
- Hits        58905    58903       -2     
- Misses     175320   175322       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @LaplaceSoda, thank you. Can I ask you to remove the style/format changes, so this PR better highlights the new preprocessor definitions?

- detect whether POSIX-style macros exist before using them
- fall back to the MSVC _S_IF* constants when needed
@LaplaceSoda LaplaceSoda force-pushed the fix_S_ISREG_macros_Windows branch from 9827616 to bb86830 Compare November 29, 2025 04:51
@LaplaceSoda
Copy link
Author

LGTM @LaplaceSoda, thank you. Can I ask you to remove the style/format changes, so this PR better highlights the new preprocessor definitions?

Done! I've removed the style/format changes and kept only the essential preprocessor definitions. Should be much clearer now.

Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait a bit longer and then merge, if there are no further comments. Thank you @LaplaceSoda.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @LaplaceSoda . LGTM.

Copy link
Contributor

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM @LaplaceSoda, thanks for this contribution!

@perazz perazz merged commit d57c776 into fortran-lang:master Nov 30, 2025
22 checks passed
@LaplaceSoda LaplaceSoda deleted the fix_S_ISREG_macros_Windows branch November 30, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build error with ifx on Windows

4 participants