Update pnpm.md with lock file info #1619
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spatten
reviewed
Nov 24, 2025
Contributor
spatten
left a comment
spatten
left a comment
There was a problem hiding this comment.
I left one comment asking what "flagged out" means. Can you clarify that?
Also, can you fill out the PR description? It doesn't have to be much, just something saying that you are adding a note to the PNPM documentation, and that this is a documentation only change.
Here's an example: #1556
|
|
||
| > 📘 Important Note | ||
| > | ||
| > Anything defined in the `importers` section will be flagged out. In order to scan individual targts, the workspace needs to have individual/separate lock files. |
Contributor
There was a problem hiding this comment.
What does "flagged out" mean? I'm assuming it means ignored, but if it does let's say that specifically
Author
There was a problem hiding this comment.
@spatten thanks for letting me know. I've updated it and submitted another request.
spatten
approved these changes
Nov 25, 2025
Contributor
spatten
left a comment
spatten
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update the pnpm documentation with a note that says that anything defined in the
importerssection will be ignoredAcceptance criteria
Testing plan
How did you validate that this PR works? What literal steps did you take when manually checking that your code works?
Example:
This section should list concrete steps that a reviewer can sanity check and repeat on their own machine (and provide any needed test cases).
Risks
Highlight any areas that you're unsure of, want feedback on, or want reviewers to pay particular attention to.
Example: I'm not sure I did X correctly, can reviewers please double-check that for me?
Metrics
Is this change something that can or should be tracked? If so, can we do it today? And how? If its easy, do it
References
Add links to any referenced GitHub issues, Zendesk tickets, Jira tickets, Slack threads, etc.
Example:
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.