Skip to content

Commit 16bd1d6

Browse files
implemented suggestions
1 parent 1043149 commit 16bd1d6

File tree

4 files changed

+188
-162
lines changed

4 files changed

+188
-162
lines changed

app/eventyay/eventyay_common/templates/eventyay_common/organizers/edit.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@
99
<h1 class="page-header">{{ organizer.name }}</h1>
1010
<ul class="nav nav-tabs" role="tablist">
1111
<li role="presentation" class="{% if active_section == 'general' %}active{% endif %}">
12-
<a href="#general" aria-controls="general" role="tab" data-toggle="tab">
12+
<a href="#" data-target="#general" aria-controls="general" role="tab" data-toggle="tab">
1313
{% translate "General" %}
1414
</a>
1515
</li>
1616
{% if can_manage_teams %}
1717
<li role="presentation" class="{% if active_section == 'teams' %}active{% endif %}">
18-
<a href="#teams" aria-controls="teams" role="tab" data-toggle="tab">
18+
<a href="#" data-target="#teams" aria-controls="teams" role="tab" data-toggle="tab">
1919
{% translate "Create Team" %}
2020
</a>
2121
</li>
2222
<li role="presentation" class="{% if active_section == 'permissions' %}active{% endif %}">
23-
<a href="#permissions" aria-controls="permissions" role="tab" data-toggle="tab">
23+
<a href="#" data-target="#permissions" aria-controls="permissions" role="tab" data-toggle="tab">
2424
{% translate "Manage Team Permissions" %}
2525
</a>
2626
</li>

app/eventyay/eventyay_common/video/permissions.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ def collect_user_video_traits(event_slug: str, team_permission_set: Iterable[str
6363
"""
6464
traits = []
6565
for perm_name in team_permission_set:
66-
definition = VIDEO_PERMISSION_BY_FIELD.get(perm_name)
67-
if definition:
66+
if definition := VIDEO_PERMISSION_BY_FIELD.get(perm_name):
6867
traits.append(definition.trait_value(event_slug))
6968
return traits
7069

0 commit comments

Comments
 (0)