implemented suggestions

Author: Saksham-Sirohi

app/eventyay/base/models/event.py

@@ -1540,7 +1540,8 @@ def get_all_permissions(self, user):
                 direct_messaging_def = VIDEO_PERMISSION_BY_FIELD.get('can_video_direct_message')
                 if direct_messaging_def and role != 'video_direct_messaging':
                     direct_messaging_trait = direct_messaging_def.trait_value(self.slug)
-                    has_direct_messaging_trait = direct_messaging_trait in user.traits
+                    traits = user.traits or []
+                    has_direct_messaging_trait = direct_messaging_trait in traits
 
                     if not has_direct_messaging_trait:
                         direct_message_value = Permission.EVENT_CHAT_DIRECT.value

app/eventyay/eventyay_common/templates/eventyay_common/organizers/edit.html

@@ -9,18 +9,18 @@
     <h1 class="page-header">{{ organizer.name }}</h1>
     <ul class="nav nav-tabs" role="tablist">
         <li role="presentation" class="{% if active_section == 'general' %}active{% endif %}">
-            <a href="#general" aria-controls="general" role="tab" data-toggle="tab">
+            <a href="#" data-target="#general" aria-controls="general" role="tab" data-toggle="tab">
                 {% translate "General" %}
             </a>
         </li>
         {% if can_manage_teams %}
         <li role="presentation" class="{% if active_section == 'teams' %}active{% endif %}">
-            <a href="#teams" aria-controls="teams" role="tab" data-toggle="tab">
+            <a href="#" data-target="#teams" aria-controls="teams" role="tab" data-toggle="tab">
                 {% translate "Create Team" %}
             </a>
         </li>
         <li role="presentation" class="{% if active_section == 'permissions' %}active{% endif %}">
-            <a href="#permissions" aria-controls="permissions" role="tab" data-toggle="tab">
+            <a href="#" data-target="#permissions" aria-controls="permissions" role="tab" data-toggle="tab">
                 {% translate "Manage Team Permissions" %}
             </a>
         </li>

app/eventyay/eventyay_common/video/permissions.py

@@ -63,8 +63,7 @@ def collect_user_video_traits(event_slug: str, team_permission_set: Iterable[str
     """
     traits = []
     for perm_name in team_permission_set:
-        definition = VIDEO_PERMISSION_BY_FIELD.get(perm_name)
-        if definition:
+        if definition := VIDEO_PERMISSION_BY_FIELD.get(perm_name):
             traits.append(definition.trait_value(event_slug))
     return traits