feat: support solc prereleases #12599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
requested review from
0xrusowsky,
DaniPopes,
mattsse,
onbjerg and
zerosnacks
as code owners
zerosnacks
previously approved these changes
Nov 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
moving to draft, will need |
grandizzy
force-pushed
the
gdzzy/chore-bump-compilers-svm
branch
2 times, most recently
from
4e29fb5 to
9683c93
Compare
grandizzy
force-pushed
the
gdzzy/chore-bump-compilers-svm
branch
from
9683c93 to
2233d22
Compare
mattsse
pushed a commit
to foundry-rs/compilers
that referenced
this pull request
Nov 19, 2025
- 8f1c61c introduced an issue with versions like `0.8.15+commit.e14f2714` format that can be seen in foundry CI failure https://github.com/foundry-rs/foundry/actions/runs/19511930077/job/55854689276?pr=12599#step:14:9999 - these versions should be normalized to e.g. `0.8.15` - only prereleases like `0.8.31-pre.1+commit.b59566f6` or `0.8.31-pre.1` should be preserved and looked up with original version - fix to preserve versions only if prereleases, foundry CI passes with patch: foundry-rs/foundry#12599 - should have created the foundry PR with patched versions to changes first, sorry for back and forth 🫠
grandizzy
force-pushed
the
gdzzy/chore-bump-compilers-svm
branch
from
2233d22 to
ecb25bf
Compare
grandizzy
changed the title
Collaborator
Author
|
rfr now, updated with proper deps |
mattsse
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist