Skip to content

Commit 9ff9c1a

Browse files
committed
fix: improve get_objs exception handling
1 parent 99e702c commit 9ff9c1a

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

easy/controller/meta.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from django.http import HttpRequest
1010
from ninja import ModelSchema
1111
from ninja_extra import ControllerBase, http_delete, http_get, http_patch, http_put
12+
from ninja_extra.exceptions import ValidationError
1213
from ninja_extra.pagination import paginate
1314

1415
from easy.controller.meta_conf import MODEL_FIELDS_ATTR_DEFAULT, ModelOptions
@@ -91,8 +92,10 @@ async def get_objs(self, request: HttpRequest, filters: Optional[str] = None) ->
9192
try:
9293
_filters = json.loads(filters)
9394
except Exception as exc: # pragma: no cover
94-
logger.warning(str(exc), exc_info=True)
95-
return []
95+
raise ValidationError(
96+
detail=f"Bad filter, please check carefully. {exc}",
97+
code=402,
98+
)
9699
return await self.service.get_objs(**_filters)
97100
return await self.service.get_objs()
98101

0 commit comments

Comments
 (0)