Skip to content

Connectivity test: peers never form direct link post aggregator #2039

@sanity

Description

@sanity

Summary

test_three_node_network_connectivity fails to form a full mesh after the event-log aggregator refactor. Gateway links come up, but peer↔peer links never appear, so the test times out.

Steps to Reproduce

  1. Checkout feat/event-log-aggregator (current PR branch).
  2. Run cargo test --test connectivity test_three_node_network_connectivity -- --nocapture.
  3. Observe that the gateway reports two peers, while each peer only lists the gateway. After ~60s the test fails.

Expected Behavior

After both peers join the gateway they should discover each other and form a direct connection, satisfying the full-mesh assertion.

Actual Behavior

  • ConnectedPeers shows each peer connected only to the gateway.
  • Event logs contain only gateway↔peer Connect events.
  • connection_maintenance never acquires additional peers (live transaction tracker stays empty).

Notes & Hypotheses

  • The aggressive bootstrap loop exits without seeding the first peer↔peer link. Skip lists or router cache may prevent forwarding recommendations beyond the gateway.
  • Extending wait times or force-adding gateways did not resolve the issue; instead bootstrap stalled.

Suggested Next Steps

  • Instrument connection_maintenance / forward_conn to see why the gateway doesn't suggest other peers once multiple peers are attached.
  • Verify whether the router cache excludes the gateway when searching for candidates.
  • After fixing discovery, restore a strict assertion in the integration test so CI keeps the mesh requirement enforced.

/cc @freenet-networking

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-networkingArea: Networking, ring protocol, peer discoveryP-mediumMedium priorityS-needs-reproductionStatus: Bug needs reproduction steps or confirmationT-bugType: Something is broken

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions