From 522706c728827a1f7902427b8430eedc85a3f8c3 Mon Sep 17 00:00:00 2001
From: Carlos Santiago <5726971+csantiago132@users.noreply.github.com>
Date: Sun, 1 Sep 2019 16:39:10 -0500
Subject: [PATCH] component updates: handles when list is empty and handles
 async loading of list

---
 .gitignore         |  1 +
 src/App.vue        | 12 ++++----
 src/At.vue         | 68 +++++++++++++++++++++++++++++++---------------
 src/AtTemplate.vue | 11 +++++++-
 4 files changed, 64 insertions(+), 28 deletions(-)

diff --git a/.gitignore b/.gitignore
index 78b3be1..9b56585 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,5 @@
 .DS_Store
+.idea/
 node_modules*/
 dist/
 npm-debug.log
diff --git a/src/App.vue b/src/App.vue
index af8e767..ee8cfe8 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -1,6 +1,6 @@
 <template>
   <div id="app">
-    <at :members="members" name-key="name" v-model="html">
+    <at :list-members="membersEmpty" name-key="name" v-model="html">
       <!-- custom: same as default slot -->
       <!-- <template v-slot:item="s">
         <span v-text="s.item"></span>
@@ -16,7 +16,7 @@
         contenteditable></div>
     </at>
 
-    <at :members="members" name-key="name" v-model="html2">
+    <at :list-members="members" name-key="name" v-model="html2">
       <template v-slot:embeddedItem="s">
         <span><span class="tag"><img class="avatar" :src="s.current.avatar">{{ s.current.name }}</span></span>
       </template>
@@ -33,7 +33,7 @@
 
     <br />
 
-    <at-ta :members="members" name-key="name" v-model="text">
+    <at-ta :list-members="members" name-key="name" v-model="text">
       <!-- custom: with avatars -->
       <template v-slot:item="s">
         <img :src="s.item.avatar">
@@ -43,7 +43,7 @@
       <textarea class="editor"></textarea>
     </at-ta>
 
-    <at-ta :members="members" name-key="name">
+    <at-ta :list-members="members" name-key="name">
       <!-- custom: with avatars -->
       <template v-slot:item="s">
         <img :src="s.item.avatar">
@@ -55,7 +55,7 @@
 
     <br />
 
-    <at-ta :members="members" name-key="name">
+    <at-ta :list-members="members" name-key="name">
       <!-- custom: with avatars -->
       <template v-slot:item="s">
         <img :src="s.item.avatar">
@@ -74,6 +74,7 @@
 import At from './At.vue'
 import AtTa from './AtTextarea.vue'
 
+let membersEmpty = []
 let members = [
   /* eslint-disable */
   "Roxie Miles","grace.carroll",
@@ -97,6 +98,7 @@ export default {
   name: 'app',
   data () {
     const data = {
+      membersEmpty,
       members,
       text: `
 <<< Textarea >>>
diff --git a/src/At.vue b/src/At.vue
index 7a8dc4d..a9ac945 100644
--- a/src/At.vue
+++ b/src/At.vue
@@ -50,17 +50,21 @@ export default {
       type: Boolean,
       default: true
     },
-    members: {
-      type: Array,
-      default: () => []
-    },
+      listMembers: {
+          type: Array,
+          default: () => []
+      },
+      isListMembersEmpty: {
+          type: String,
+          default: 'There is no one to tag'
+      },
     nameKey: {
       type: String,
       default: ''
     },
     filterMatch: {
       type: Function,
-      default: (name, chunk, at) => {
+      default: (name = this.value, chunk, at) => {
         // match at lower-case
         return name.toLowerCase()
           .indexOf(chunk.toLowerCase()) > -1
@@ -83,6 +87,7 @@ export default {
       // at[v-model] mode should be on only when
       // initial :value/v-model is present (not nil)
       bindsValue: this.value != null,
+        members: this.listMembers,
       customsEmbedded: false,
       hasComposition: false,
       atwho: null
@@ -118,14 +123,14 @@ export default {
   },
   watch: {
     'atwho.cur' (index) {
-      if (index != null) { // cur index exists
+      if (index !== null) { // cur index exists
         this.$nextTick(() => {
           this.scrollToCur()
         })
       }
     },
-    members () {
-      this.handleInput(true)
+    listMembers (nextValue) {
+        this.members = nextValue
     },
     value (value, oldValue) {
       if (this.bindsValue) {
@@ -144,8 +149,14 @@ export default {
 
   methods: {
     itemName (v) {
-      const { nameKey } = this
-      return nameKey ? v[nameKey] : v
+        /**
+         * checks if list is empty, we return empty string
+         */
+        if (v) {
+            const { nameKey } = this
+            return nameKey ? v[nameKey] : v
+        }
+        return ''
     },
     isCur (index) {
       return index === this.atwho.cur
@@ -323,16 +334,16 @@ export default {
             return filterMatch(name, chunk, at)
           })
 
-          show = false
-          if (matched.length) {
+            /**
+             * we open the modal regardless
+             */
             show = true
             if (!showUnique) {
-              let item = matched[0]
-              if (chunk === itemName(item)) {
-                show = false
-              }
+                let item = matched[0]
+                if (chunk === itemName(item)) {
+                    show = false
+                }
             }
-          }
 
           if (show) {
             this.openPanel(matched, range, index, at)
@@ -357,7 +368,8 @@ export default {
         this.atwho = {
           range,
           offset,
-          list,
+            // sets empty list to handle how to display empty list
+          list: list.length > 0 ? list : [],
           x: rect.left,
           y: rect.top - 4,
           cur: 0 // todo: 尽可能记录
@@ -371,9 +383,21 @@ export default {
     },
 
     scrollToCur () {
-      const curEl = this.$refs.cur[0]
-      const scrollParent = curEl.parentElement.parentElement // .atwho-view
-      scrollIntoView(curEl, scrollParent)
+        /**
+         * checks if li element li.atwho-li.atwho-cur exists
+         * we need to check because if list is empty, we display empty message
+         */
+        if(this.$refs.cur) {
+            /**
+             * checks that the fist element of the list is defined
+             * and avoid making this function error out
+             */
+            if (this.$refs.cur[0]) {
+                const curEl = this.$refs.cur[0]
+                const scrollParent = curEl.parentElement.parentElement // .atwho-view
+                scrollIntoView(curEl, scrollParent)
+            }
+        }
     },
     selectByMouse (e) {
       const el = closest(e.target, d => {
@@ -386,7 +410,7 @@ export default {
       }
     },
     selectByKeyboard (e) {
-      const offset = e.keyCode === 38 ? -1 : 1
+        const offset = e.keyCode === 38 || e.keyCode === 13 ? -1 : 1;
       const { cur, list } = this.atwho
       const nextCur = this.loop
         ? (cur + offset + list.length) % list.length
diff --git a/src/AtTemplate.vue b/src/AtTemplate.vue
index 8a1ef2d..9884821 100644
--- a/src/AtTemplate.vue
+++ b/src/AtTemplate.vue
@@ -14,7 +14,7 @@
     >
       <div class="atwho-inner">
         <div class="atwho-view">
-          <ul class="atwho-ul">
+          <ul class="atwho-ul" v-if="atwho.list.length > 0">
             <li v-for="(item, index) in atwho.list"
               class="atwho-li"
               :key="index"
@@ -29,9 +29,18 @@
               </slot>
             </li>
           </ul>
+          <!--   to improve UX, we can display something when the list is empty   -->
+          <ul class="atwho-ul" v-if="atwho.list.length === 0">
+            <li class="atwho-li">
+              <slot name="emptyList">
+                <span v-text="isListMembersEmpty"></span>
+              </slot>
+            </li>
+          </ul>
         </div>
       </div>
     </div>
+
     <span v-show="false" ref="embeddedItem">
       <slot name="embeddedItem" :current="currentItem"></slot>
     </span>