kwargs not propagated to BlobServiceClient

[vladidobro]

From the PyPI docs:

The AzureBlobFileSystem accepts all of the Async BlobServiceClient arguments.

But after debugging while my retry configuration is not propagated

In [32]: b = fsspec.filesystem('az', account_name='account', anon=False, retry_total=8)

In [33]: b.service_client._pipeline._impl_policies[10]
Out[33]: <azure.storage.blob._shared.policies_async.ExponentialRetry at 0x114fdaea0>

In [34]: b.service_client._pipeline._impl_policies[10].total_retries
Out[34]: 3

I read the code and it seems that creating the BlobServiceClient is completely oblivious to the AzureBlobFileSystem kwargs
https://github.com/fsspec/adlfs/blob/main/adlfs/spec.py#L465

It seems like this is not intended, or did I understand something wrong?
It feels like it should be enough to pass **self.kwargs to the BlobServiceClient constructors, but I am not sure.

[anjaliratnam-msft]

@vladidobro
It looks like you are right, the kwargs are not getting passed to the BlobServiceClient when it’s created. The documentation is incorrect here, so we'll fix that. In the future it would make sense to support the client kwargs that the SDK supports, but we would have to do additional research to determine how we’d want to generalize this. We can mark this as a feature request for now.

[vladidobro]

Thank you!

For people looking for a fix, it seems like currently the only way to do it is to patch the service_client after creation

import adlfs
from azure.storage.blob.aio import BlobServiceClient

fs = adlfs.AzureBlobFileSystem(
    account_name='myaccount',
    anon=False,
)
fs.service_client = BlobServiceClient(
    account_url=f'https://{fs.account_name}.blob.core.windows.net',
    credential=fs.credential,
    retry_total=8,
)

print(fs.service_client._pipeline._impl_policies[10].total_retries)  # type: ignore
# 8