Skip to content

Commit 3f9cba2

Browse files
committed
PicassoSupport & GlideSupport: Fix crash when no placeholder
Signed-off-by: Fung <fython@163.com>
1 parent 9cd0293 commit 3f9cba2

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
BUILD_TOOLS_VERSION=25.0.3
22
org.gradle.jvmargs=-Xmx1536m
3-
VERSION_NAME=0.1.4.1
3+
VERSION_NAME=0.1.4.2
44
TARGET_SDK_VERSION=25
55
VERSION_CODE=2
66
MIN_SDK_VERSION=19

kotlinyan-glide-support/src/main/kotlin/moe/feng/kotlinyan/common/GlideExtensions.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import java.io.File
1111

1212
interface GlideExtensions {
1313

14-
var ImageView.placeholderResource : Int
15-
get() { return this.getTag(R.id.tag_glide_placeholder_res) as Int }
14+
var ImageView.placeholderResource : Int?
15+
get() { return this.getTag(R.id.tag_glide_placeholder_res) as? Int }
1616
set(value) {
1717
this.setTag(R.id.tag_glide_placeholder_drawable, null)
1818
this.setTag(R.id.tag_glide_placeholder_res, value)
@@ -58,7 +58,7 @@ interface GlideExtensions {
5858
}
5959

6060
private fun <A, B, C, D> ImageView.makeGlideRequest(request: GenericRequestBuilder<A, B, C, D>) {
61-
if (placeholderResource != 0) request.placeholder(placeholderResource)
61+
if (placeholderResource != null && placeholderResource != 0) request.placeholder(placeholderResource!!)
6262
if (placeholder != null) request.placeholder(placeholder)
6363
if (glideListener != null) request.listener(glideListener as RequestListener<A, D>)
6464
val transformer = getTag(R.id.tag_glide_builder_transformer) as? GenericRequestBuilder<A, B, C, D>.() -> Unit

kotlinyan-picasso-support/src/main/kotlin/moe/feng/kotlinyan/common/PicassoExtensions.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ interface PicassoExtensions {
1515
private val ANIMATION_DURATION : Int = 1000
1616
}
1717

18-
var ImageView.placeholderResource : Int
19-
get() { return this.getTag(R.id.tag_picasso_placeholder_res) as Int }
18+
var ImageView.placeholderResource : Int?
19+
get() { return this.getTag(R.id.tag_picasso_placeholder_res) as? Int }
2020
set(value) {
2121
this.setTag(R.id.tag_picasso_placeholder_drawable, null)
2222
this.setTag(R.id.tag_picasso_placeholder_res, value)
@@ -60,7 +60,7 @@ interface PicassoExtensions {
6060
}
6161

6262
private fun ImageView.makePicassoRequest(request: RequestCreator) {
63-
if (placeholderResource != 0) request.placeholder(placeholderResource)
63+
if (placeholderResource != null && placeholderResource != 0) request.placeholder(placeholderResource!!)
6464
if (placeholder != null) request.placeholder(placeholder)
6565
val transformer = getTag(R.id.tag_picasso_request_transfomer) as? RequestCreator.() -> Unit
6666
transformer?.let { it(request) }

0 commit comments

Comments
 (0)