Skip to content

Fix incorrect MachineInformer callback #988

@elankath

Description

@elankath

How to categorize this issue?

/area control-plane
/kind bug
/priority 3

What happened:

A Machine informer callback incorrectly calls the wrong callback function as seen here:

DeleteFunc: controller.deleteMachineDeployment,
. Though this thankfully doesn't result in errors due to the cast check, it is semantically incorrect and must be fixed.

What you expected to happen:

The Machine informer delete callback should correctly call deleteMachineToMachineDeployment

How to reproduce it (as minimally and precisely as possible):
Setup local MCM, Add a log statement to callback, delete a Machine object and observe bad callback being invoked.

Anything else we need to know?:
NA

Environment:

NA

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions