Fix crash and synchronize gui when disabling gi with active debug visualization mode (#3062)

When gi is being disabled (Enabled changes from true to false), the code sets the debug visualization mode to None, marks it as dirty, and sets a flag. After releasing the mutex lock, if the flag is set, it emits the DebugVisualizationModeChanged signal to notify the GUI to update.

This ensures internal state consistency and prevents crashes by forcing the debug visualization mode to None when gi is off. Emitting the signal outside the lock avoids deadlocks and keeps the GUI synchronized with the internal state.


Signed-off-by: momo <2438833481@qq.com>

Author: XINJIANGMO

src/gui/plugins/global_illumination_vct/GlobalIlluminationVct.cc

@@ -549,9 +549,23 @@ void GlobalIlluminationVct::UpdateOctantCount(int _axis, uint32_t _count)
 //////////////////////////////////////////////////
 void GlobalIlluminationVct::SetEnabled(const bool _enabled)
 {
-  std::lock_guard<std::mutex> lock(this->dataPtr->serviceMutex);
-  this->dataPtr->enabled = _enabled;
-  this->dataPtr->visualDirty = true;
+  bool needEmitDebugVisChanged = false;
+  {
+    std::lock_guard<std::mutex> lock(this->dataPtr->serviceMutex);
+    if (this->dataPtr->enabled && !_enabled)
+    {
+      // When disabling GI, force debugVisMode to None for safety
+      this->dataPtr->debugVisMode = rendering::GlobalIlluminationVct::DVM_None;
+      this->dataPtr->debugVisualizationDirty = true;
+      needEmitDebugVisChanged = true;
+    }
+    this->dataPtr->enabled = _enabled;
+    this->dataPtr->visualDirty = true;
+  }
+  if (needEmitDebugVisChanged)
+  {
+    this->DebugVisualizationModeChanged();
+  }
 }
 
 //////////////////////////////////////////////////