Fix help text display issue in JointPositionController plugin #3118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: momo <2438833481@qq.com>
arjo129
approved these changes
Oct 16, 2025
Contributor
arjo129
left a comment
arjo129
left a comment
There was a problem hiding this comment.
Tested, this seems to work as expected. Thanks for the fix!!
Contributor
|
P.S. I recommend targeting main now that jetty is out. We need to remember to forward port this fix once its merged. |
iche033
approved these changes
Oct 16, 2025
Contributor
|
@Mergifyio backport main |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 7, 2025
Signed-off-by: momo <2438833481@qq.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit bc6d786)
7 tasks
iche033
added a commit
that referenced
this pull request
Nov 7, 2025
Signed-off-by: momo <2438833481@qq.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit bc6d786)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3117
Summary
change
parentproperty toApplicationWindow.overlay(previous usage in formergz-simversion) or simplyoverlayChecklist
codecheckpassed (See contributing)