Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 29, 2025

🦟 Bug fix

Summary

Without this fix, if for any reason the invocation of the gz-sim-gui-client fails on Windows, the gz-sim-main process (or the parent process gz) silently exits, that may be confusing for users.

See conda-forge/gz-sim-feedstock#110 .

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #3104 done by [Mergify](https://mergify.com).

Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
(cherry picked from commit 08dc62d)
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 29, 2025
@arjo129 arjo129 merged commit ac4d5a3 into main Oct 29, 2025
13 of 14 checks passed
@arjo129 arjo129 deleted the mergify/bp/main/pr-3104 branch October 29, 2025 23:11
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants