Implemented is_appellate_case verifier for legal applications, along … #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with tests and test data
nrfulton
approved these changes
Nov 4, 2025
Contributor
nrfulton
left a comment
nrfulton
left a comment
There was a problem hiding this comment.
Please review these comments. Otherwise, LGTM.
| def is_appellate_court(court_name: str) -> ValidationResult: | ||
| """Determine if a court is an appellate court based on its name.""" | ||
| # rule exceptions: the 2 appellate courts whose names do not include the below keywords | ||
| rule_exceptions = ["pennsylvania superior court", "pennsylvania commonwealth court"] |
Contributor
There was a problem hiding this comment.
- Are you sure that these are the only two exceptions?
- Do we need to handle abbreviations of court names, or can we always expect that the full court name will be provided as input to this function?
Author
There was a problem hiding this comment.
- From my research, I'm pretty sure that's the case!
- From our check-in meeting this week, we decided that we can table this for now but leave this as a comment for the future. In all the case metadata files I downloaded from the Caselaw Access Project, the court name was given as the full name
| def __init__(self, folder_path): | ||
| self.folder_path = folder_path | ||
| super().__init__( | ||
| description="The result should be an appellate court case.", |
Author
There was a problem hiding this comment.
Supriya and I agreed that I could implement this assuming the input would just be the name of a case, not the citation—should that be changed though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with tests and test data