Fix Null Dereference and Privacy Violation issues. (#763)

claudiamurialdo · web-flow · commit db2c492c61d4 · 2023-02-03T17:22:18.000-03:00
* Fix  Null Dereference and Privacy Violation issues.

* Fix Null Dereference

* Undo changes on FabricConnection. It will be removed.
diff --git a/dotnet/src/dotnetframework/GxClasses/Data/GXDataMysqlDriverCS.cs b/dotnet/src/dotnetframework/GxClasses/Data/GXDataMysqlDriverCS.cs
@@ -97,7 +97,6 @@ protected override string BuildConnectionString(string datasourceName, string us
 			string maxpoolSize = GetParameterValue(connstr, "Max Pool Size");
 			if (String.IsNullOrEmpty(maxpoolSize)) MAX_TRIES = 100; 
 			else MAX_TRIES = Convert.ToInt32(maxpoolSize);
-			GXLogging.Debug(log, "MAX_TRIES=" + MAX_TRIES);
 			return connstr;
 		}
 		public override bool AllowsDuplicateParameters
diff --git a/dotnet/src/extensions/Azure/Handlers/QueueHandler/QueueTriggerHandler.cs b/dotnet/src/extensions/Azure/Handlers/QueueHandler/QueueTriggerHandler.cs
@@ -78,7 +78,7 @@ private QueueMessage SetupMessage(FunctionContext context, string item)
 		private void ProcessMessage(FunctionContext context, ILogger log, QueueMessage queueMessage)
 		{
 			CallMappings callmap = (CallMappings)_callmappings;
-			GxAzMappings map = callmap.mappings is object ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
+			GxAzMappings map = (callmap!=null && callmap.mappings is object) ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
 			string gxProcedure = map is object ? map.GXEntrypoint : string.Empty;
 
 			string exMessage;
diff --git a/dotnet/src/extensions/Azure/Handlers/ServiceBusHandler/ServiceBusTriggerHandler.cs b/dotnet/src/extensions/Azure/Handlers/ServiceBusHandler/ServiceBusTriggerHandler.cs
@@ -102,7 +102,7 @@ private Message SetupMessage(FunctionContext context, string item)
 		private void ProcessMessage(FunctionContext context, ILogger log, Message message)
 		{
 			CallMappings callmap = (CallMappings)_callmappings;
-			GxAzMappings map = callmap.mappings is object ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
+			GxAzMappings map = (callmap!=null && callmap.mappings is object) ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
 			string gxProcedure = map is object ? map.GXEntrypoint : string.Empty;
 
 			string exMessage;
diff --git a/dotnet/src/extensions/Azure/Handlers/TimerHandler/TimerTriggerHandler.cs b/dotnet/src/extensions/Azure/Handlers/TimerHandler/TimerTriggerHandler.cs
@@ -43,7 +43,7 @@ private void ProcessMessage(FunctionContext context, ILogger log, MyInfo TimerIn
 			CallMappings callmap = (CallMappings)_callmappings;
 
 			GxAzMappings map = callmap.mappings is object ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
-			string gxProcedure = map is object ? map.GXEntrypoint : string.Empty;
+			string gxProcedure = (map != null && map is object) ? map.GXEntrypoint : string.Empty;
 			string exMessage;
 
 			if (!string.IsNullOrEmpty(gxProcedure))

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,6 @@ protected override string BuildConnectionString(string datasourceName, string us`
`97`	`97`	`string maxpoolSize = GetParameterValue(connstr, "Max Pool Size");`
`98`	`98`	`if (String.IsNullOrEmpty(maxpoolSize)) MAX_TRIES = 100;`
`99`	`99`	`else MAX_TRIES = Convert.ToInt32(maxpoolSize);`
`100`		`- GXLogging.Debug(log, "MAX_TRIES=" + MAX_TRIES);`
`101`	`100`	`return connstr;`
`102`	`101`	`}`
`103`	`102`	`public override bool AllowsDuplicateParameters`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ private QueueMessage SetupMessage(FunctionContext context, string item)`
`78`	`78`	`private void ProcessMessage(FunctionContext context, ILogger log, QueueMessage queueMessage)`
`79`	`79`	`{`
`80`	`80`	`CallMappings callmap = (CallMappings)_callmappings;`
`81`		`- GxAzMappings map = callmap.mappings is object ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;`
	`81`	`+ GxAzMappings map = (callmap!=null && callmap.mappings is object) ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;`
`82`	`82`	`string gxProcedure = map is object ? map.GXEntrypoint : string.Empty;`
`83`	`83`
`84`	`84`	`string exMessage;`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ private Message SetupMessage(FunctionContext context, string item)`
`102`	`102`	`private void ProcessMessage(FunctionContext context, ILogger log, Message message)`
`103`	`103`	`{`
`104`	`104`	`CallMappings callmap = (CallMappings)_callmappings;`
`105`		`- GxAzMappings map = callmap.mappings is object ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;`
	`105`	`+ GxAzMappings map = (callmap!=null && callmap.mappings is object) ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;`
`106`	`106`	`string gxProcedure = map is object ? map.GXEntrypoint : string.Empty;`
`107`	`107`
`108`	`108`	`string exMessage;`