Update test_path.py

Author: jnsebgosselin

qtapputils/widgets/tests/test_path.py

@@ -17,6 +17,7 @@
 # ---- Third party imports
 import pytest
 from qtpy.QtCore import Qt
+from qtpy.QtGui import QIcon
 
 # ---- Local imports
 from qtapputils.widgets.path import PathBoxWidget, QFileDialog
@@ -29,8 +30,6 @@
 def pathbox(qtbot):
     pathbox = PathBoxWidget(
         parent=None,
-        path='',
-        directory='',
         path_type='getSaveFileName',
         filters=None
         )
@@ -42,32 +41,138 @@ def pathbox(qtbot):
 # =============================================================================
 # ---- Tests for the PathBoxWidget
 # =============================================================================
-def test_getopen_filename(qtbot, pathbox, mocker, tmp_path):
-    """Test that getting a file name is working as expected."""
+def test_initialization_no_icon(qtbot):
+    pathbox = PathBoxWidget()
+    qtbot.addWidget(pathbox)
+
+    assert pathbox.is_empty()
     assert not pathbox.is_valid()
+    assert pathbox.path() == ""
+    assert pathbox.directory()
+
+
+def test_initialization_with_icon(qtbot):
+    icon = QIcon()
+    pathbox = PathBoxWidget(browse_icon=icon)
+    qtbot.addWidget(pathbox)
+
     assert pathbox.is_empty()
-    assert pathbox.path() == ''
-    assert osp.samefile(pathbox.directory(), osp.expanduser('~'))
+    assert not pathbox.is_valid()
 
-    # Create an empty file.
-    selectedfilter = 'Text File (*.txt)'
-    selectedfilename = osp.join(tmp_path, 'pathbox_testfile.txt')
-    with open(selectedfilename, 'w') as txtfile:
-        txtfile.write('test')
 
-    # Patch the open file dialog and select the test file.
+def test_set_and_get_path_valid(tmp_path, qtbot):
+    # Create a valid file
+    f = tmp_path / "myfile.txt"
+    f.write_text("content")
+
+    pathbox = PathBoxWidget(path_type="getOpenFileName")
+    qtbot.addWidget(pathbox)
+    pathbox.set_path(str(f))
+
+    assert not pathbox.is_empty()
+    assert pathbox.is_valid()
+    assert pathbox.path() == str(f)
+    assert pathbox.directory() == str(tmp_path)
+
+
+def test_set_and_get_path_invalid(qtbot):
+    pathbox = PathBoxWidget()
+    qtbot.addWidget(pathbox)
+    pathbox.set_path("/tmp/nonexistent_file.txt")
+
+    assert pathbox.path() == "/tmp/nonexistent_file.txt"
+    assert pathbox.directory() == osp.expanduser('~')
+    assert not pathbox.is_valid()
+
+
+def test_set_directory_valid(tmp_path, qtbot):
+    d = tmp_path / "dir"
+    d.mkdir()
+
+    pathbox = PathBoxWidget()
+    qtbot.addWidget(pathbox)
+    pathbox.set_directory(str(d))
+
+    assert pathbox.directory() == str(d)
+
+
+def test_set_directory_invalid(qtbot):
+    pathbox = PathBoxWidget()
+    qtbot.addWidget(pathbox)
+    pathbox.set_directory("/tmp/nonexistent_dir")
+
+    # Should fallback to home if directory is invalid
+    assert pathbox.directory() == osp.expanduser('~')
+
+
+def test_signal_emitted_on_path_change(tmp_path, qtbot):
+    f = tmp_path / "file.txt"
+    f.write_text("abc")
+
+    pathbox = PathBoxWidget()
+    qtbot.addWidget(pathbox)
+
+    with qtbot.waitSignal(pathbox.sig_path_changed) as blocker:
+        pathbox.set_path(str(f))
+    assert blocker.args == [str(f)]
+
+
+def test_browse_path_get_existing_directory(mocker, tmp_path, qtbot):
+    d = tmp_path / "bro_dir"
+    d.mkdir()
+
+    pathbox = PathBoxWidget(path_type="getExistingDirectory")
+    qtbot.addWidget(pathbox)
+
     qfdialog_patcher = mocker.patch.object(
         QFileDialog,
-        'getSaveFileName',
-        return_value=(selectedfilename, selectedfilter)
+        'getExistingDirectory',
+        return_value=str(d)
         )
-    qtbot.mouseClick(pathbox.browse_btn, Qt.LeftButton)
 
+    pathbox.browse_path()
     assert qfdialog_patcher.call_count == 1
+    assert pathbox.path() == str(d)
+    assert pathbox.directory() == str(tmp_path)
     assert pathbox.is_valid()
-    assert not pathbox.is_empty()
-    assert pathbox.path() == selectedfilename
-    assert osp.samefile(pathbox.directory(), tmp_path)
+
+
+def test_browse_path_get_open_file_name(mocker, tmp_path, qtbot):
+    f = tmp_path / "bro_file.txt"
+    f.write_text("abc")
+
+    pathbox = PathBoxWidget(path_type="getOpenFileName")
+    qtbot.addWidget(pathbox)
+
+    qfdialog_patcher = mocker.patch.object(
+        QFileDialog,
+        'getOpenFileName',
+        return_value=(str(f), "")
+        )
+
+    pathbox.browse_path()
+    assert qfdialog_patcher.call_count == 1
+    assert pathbox.path() == str(f)
+    assert pathbox.directory() == str(tmp_path)
+    assert pathbox.is_valid()
+
+
+def test_browse_path_get_save_file_name(mocker, tmp_path, qtbot):
+    f = tmp_path / "save_file.txt"
+
+    pathbox = PathBoxWidget(path_type="getSaveFileName")
+    qtbot.addWidget(pathbox)
+
+    qfdialog_patcher = mocker.patch.object(
+        QFileDialog,
+        'getSaveFileName',
+        return_value=(str(f), "")
+        )
+
+    pathbox.browse_path()
+    assert qfdialog_patcher.call_count == 1
+    assert pathbox.path() == str(f)
+    assert pathbox.directory() == str(tmp_path)
 
 
 if __name__ == "__main__":