Skip to content

Commit 06886d0

Browse files
NicolappsConvex, Inc.
authored andcommitted
ESLint: Remove incorrect hasSuggestions on rules (#41771)
This was suggested by the `require-meta-has-suggestions` rule of `eslint-plugin-eslint-plugin`: ``` /Users/nicolas/Documents/convex/npm-packages/@convex-dev/eslint-plugin/src/lib/noMissingArgs.ts 154:21 error `meta.hasSuggestions` cannot be `true` for non-suggestable rules eslint-plugin/require-meta-has-suggestions ``` Looking at it in details, it looks like these rules provide _fixes_ (🔧) but not _suggestions_ (💡), so setting `hasSuggestions` is incorrect. GitOrigin-RevId: 45fbe897594dd8135882b3c4409938698f2baa5f
1 parent db3d8ea commit 06886d0

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

npm-packages/@convex-dev/eslint-plugin/src/lib/noMissingArgs.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ export const noMissingArgs = createRule({
7979
},
8080
schema: [],
8181
fixable: "code",
82-
hasSuggestions: true,
8382
},
8483
defaultOptions: [],
8584
create: (context) => {
@@ -147,7 +146,6 @@ export const noArgsWithoutValidator = createRule({
147146
},
148147
schema: [],
149148
fixable: "code",
150-
hasSuggestions: true,
151149
},
152150
defaultOptions: [],
153151
create: (context) => {

0 commit comments

Comments
 (0)