system-udfs: migrate to ESLint 9 (#42396)

GitOrigin-RevId: 2365ec2947eb2aa0a7a5c248ac33b16a4430663d

Author: Nicolapps

npm-packages/common/config/rush/pnpm-lock.yaml

@@ -56,7 +56,6 @@ export const fileMetadata = queryGeneric({
 
     const newPage = await Promise.all(
       files.page.map(async (file) => {
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         const url = (await storage.getUrl(file._id))!;
         return {
           url,

npm-packages/system-udfs/convex/.eslintrc.cjs

@@ -11,7 +11,7 @@ export default queryGeneric({
     const id = args.id as GenericId<string>;
     try {
       return await db.get(id);
-    } catch (e) {
+    } catch {
       return await db.system.get(id as GenericId<SystemTableNames>);
     }
   },

npm-packages/system-udfs/convex/_system/frontend/fileStorageV2.ts

@@ -263,7 +263,7 @@ export async function findErrorsInFilters(
     if (filter.value) {
       try {
         jsonToConvex(filter.value);
-      } catch (e) {
+      } catch {
         errors.push({
           filter: i,
           error: `Invalid value: ${JSON.stringify(filter.value)}.`,
@@ -619,7 +619,7 @@ function jsonToConvexOrValue(
   }
   try {
     return jsonToConvex(value);
-  } catch (e) {
+  } catch {
     return value;
   }
 }

npm-packages/system-udfs/convex/_system/frontend/getById.ts

@@ -64,7 +64,9 @@ export default queryGeneric({
     // This will throw an error if parsedFilters does not match the filter expression schema,
     // which should only happens if a dashboard user manually edits the `filters` query parameter
     // the dashboard should not allow this to happen by deleting the query parameter if it is invalid.
-    parsedFilters && FilterExpressionSchema.parse(parsedFilters);
+    if (parsedFilters) {
+      FilterExpressionSchema.parse(parsedFilters);
+    }
 
     if (parsedFilters && parsedFilters.clauses?.length) {
       const errors = await findErrorsInFilters(parsedFilters);

npm-packages/system-udfs/convex/_system/frontend/lib/filters.ts

@@ -0,0 +1,105 @@
+import { defineConfig, globalIgnores } from "eslint/config";
+
+import eslint from "@eslint/js";
+import reactHooks from "eslint-plugin-react-hooks";
+import react from "eslint-plugin-react";
+import tseslint, { parser as tsParser } from "typescript-eslint";
+
+import { fileURLToPath } from "node:url";
+import { dirname, join } from "node:path";
+
+import { fixupPluginRules } from "@eslint/compat";
+
+import js from "@eslint/js";
+
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+export default defineConfig([
+  eslint.configs.recommended,
+  tseslint.configs.recommended,
+  {
+    languageOptions: {
+      parser: tsParser,
+
+      parserOptions: {
+        project: join(__dirname, "tsconfig.json"),
+        tsconfigRootDir: __dirname,
+      },
+    },
+
+    plugins: {
+      "react-hooks": fixupPluginRules(reactHooks),
+      react,
+    },
+
+    extends: compat.extends("prettier"),
+
+    rules: {
+      // we use any to access internal-only APIs in Convex functions
+      "@typescript-eslint/no-explicit-any": "off",
+
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          varsIgnorePattern: "_.*",
+        },
+      ],
+
+      "@typescript-eslint/no-floating-promises": "error",
+
+      // system UDF argument validation
+      "no-restricted-imports": [
+        "error",
+        {
+          patterns: [
+            {
+              group: ["**/_generated/server"],
+
+              importNames: [
+                "query",
+                "mutation",
+                "action",
+                "internalQuery",
+                "internalMutation",
+                "internalAction",
+              ],
+
+              message:
+                "Use the query wrappers from convex/_system/server.ts instead for system UDF argument validation.",
+            },
+            {
+              group: ["convex/server"],
+
+              importNames: [
+                "queryGeneric",
+                "mutationGeneric",
+                "actionGeneric",
+                "internalQueryGeneric",
+                "internalMutationGeneric",
+                "internalActionGeneric",
+              ],
+
+              message:
+                "Use the query wrappers from convex/_system/server.ts instead for system UDF argument validation.",
+            },
+          ],
+        },
+      ],
+    },
+  },
+  globalIgnores([
+    "**/node_modules",
+    "**/dist",
+    "**/_generated",
+    "eslint.config.mjs",
+  ]),
+]);

npm-packages/system-udfs/convex/_system/frontend/paginatedTableDocuments.ts

@@ -7,7 +7,7 @@
   "scripts": {
     "build": "rm -rf dist && tsc",
     "clean": "rm -rf dist",
-    "lint": "tsc && cd convex && eslint .",
+    "lint": "tsc && eslint .",
     "prepare": "npm run build",
     "test": "vitest run --pass-with-no-tests"
   },
@@ -25,18 +25,20 @@
     "udf-syscall-ffi": "workspace:*"
   },
   "devDependencies": {
+    "@eslint/compat": "~1.3.0",
+    "@eslint/eslintrc": "~3.3.0",
+    "@eslint/js": "~9.34.0",
     "@types/object-inspect": "^1.8.1",
     "@types/lodash": "~4.17.0",
     "@types/node": "^18.17.0",
     "convex-test": "^0.0.38",
-    "eslint": "^8.29.0",
-    "eslint-plugin-react-hooks": "^5.1.0-beta-26f2496093-20240514",
-    "eslint-plugin-react": "^7.37.2",
-    "vitest": "^3.2.4",
-    "@typescript-eslint/eslint-plugin": "^6.7.4",
-    "@typescript-eslint/parser": "^6.7.4",
+    "eslint": "^9.37.0",
     "eslint-config-prettier": "^10.0.0",
     "eslint-plugin-prettier": "^5.0.0",
-    "typescript": "~5.0.3"
+    "eslint-plugin-react": "^7.37.2",
+    "eslint-plugin-react-hooks": "^4.6.2",
+    "typescript": "~5.0.3",
+    "typescript-eslint": "^8.45.0",
+    "vitest": "^3.2.4"
   }
 }