Add a project for lint tools (#43123)

Nicolapps · Convex, Inc. · commit 85dbac35a528 · 2025-11-15T02:34:06.000Z
This moves eslint and dprint/prettier dependencies to a Rush package. It makes dependency management easier, and will also allow us to allow linting to depend on monorepo packages in the future.

I also updated linter dependencies across the monorepo for consistency.

GitOrigin-RevId: b41f6da1d714364b513da671a35c84ebe587840b
diff --git a/.github/workflows/prettier.yml b/.github/workflows/prettier.yml
@@ -28,7 +28,7 @@ jobs:
 
       - name: Get dprint version
         run: |
-          echo DPRINT_VERSION=$(node -p "require('./scripts/package.json').devDependencies['dprint']") >> $GITHUB_ENV
+          echo DPRINT_VERSION=$(node -p "require('./npm-packages/lint/package.json').devDependencies['dprint']") >> $GITHUB_ENV
 
       - uses: dprint/check@v2.3
         with:
diff --git a/npm-packages/@convex-dev/design-system/package.json b/npm-packages/@convex-dev/design-system/package.json
@@ -57,7 +57,7 @@
     "eslint-plugin-import": "^2.30.0",
     "eslint-plugin-jsx-a11y": "^6.6.0",
     "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-react": "^7.37.2",
+    "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^4.6.2",
     "jest": "^29.6.0",
     "jest-environment-jsdom": "^29.5.0",
diff --git a/npm-packages/common/config/rush/common-versions.json b/npm-packages/common/config/rush/common-versions.json
@@ -109,7 +109,8 @@
     "@types/react": ["^18", "^18.3.17", "^18.2.65"],
     "@types/react-dom": ["^18", "^18.3.1", "^18.2.21"],
     "typescript-eslint": ["^8.45.0"],
-    "@typescript-eslint/eslint-plugin": ["^8.45.0"],
+    "@typescript-eslint/eslint-plugin": ["^6.7.4"], // TODO(nicolas) Update the dashboard ESLint config
+    "@typescript-eslint/parser": ["^6.7.4"], // TODO(nicolas) Update the dashboard ESLint config
     //"eslint": ["^8"],
     "@eslint/eslintrc": ["^3"],
     "eslint-config-next": ["~13.4.16", "15.2.3"],
diff --git a/npm-packages/common/config/rush/pnpm-lock.yaml b/npm-packages/common/config/rush/pnpm-lock.yaml
diff --git a/npm-packages/common/config/rush/repo-state.json b/npm-packages/common/config/rush/repo-state.json
@@ -1,5 +1,5 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
   "preferredVersionsHash": "9e868af9e9249b1e68ae3b3da499e674c39e4cdc",
-  "packageJsonInjectedDependenciesHash": "1e395ecc0784b479582f69d595d282c4140c95cd"
+  "packageJsonInjectedDependenciesHash": "510a1c559e55b153de42644845c8e87139272475"
 }
diff --git a/npm-packages/convex-ai-chat/package.json b/npm-packages/convex-ai-chat/package.json
@@ -65,12 +65,12 @@
     "convex": "workspace:*",
     "@types/react": "^18.0.0",
     "@types/react-dom": "^18.0.0",
-    "@typescript-eslint/eslint-plugin": "^6.7.4",
-    "@typescript-eslint/parser": "^6.7.4",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
     "eslint": "^8.29.0",
     "eslint-config-prettier": "^10.0.0",
-    "eslint-plugin-react": "^7.37.2",
-    "eslint-plugin-react-hooks": "^5.1.0-beta-26f2496093-20240514",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
     "react": "^18.0.0",
     "react-dom": "^18.0.0",
     "tailwindcss": "^3.2.4",
diff --git a/npm-packages/convex/package.json b/npm-packages/convex/package.json
@@ -300,8 +300,8 @@
     "esbuild-plugin-external-global": "~1.0.1",
     "eslint": "^9.37.0",
     "eslint-config-prettier": "^10.0.0",
-    "eslint-plugin-react": "^7.37.2",
-    "eslint-plugin-react-hooks": "^5.1.0-beta-26f2496093-20240514",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-require-extensions": "~0.1.3",
     "fetch-retry": "~6.0.0",
     "find-up": "^7.0.0",
diff --git a/npm-packages/dashboard-common/package.json b/npm-packages/dashboard-common/package.json
@@ -102,7 +102,7 @@
     "eslint-plugin-better-tailwindcss": "^3.4.4",
     "eslint-plugin-jsx-a11y": "^6.6.0",
     "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-react": "^7.37.2",
+    "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^4.6.2",
     "eslint-plugin-storybook": "^9.0.17",
     "jest": "^29.6.0",
diff --git a/npm-packages/dashboard-self-hosted/package.json b/npm-packages/dashboard-self-hosted/package.json
@@ -42,7 +42,7 @@
     "eslint-plugin-import": "^2.30.0",
     "eslint-plugin-jsx-a11y": "^6.6.0",
     "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-react": "^7.37.2",
+    "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^4.6.2",
     "postcss": "^8.4.19",
     "prettier": "3.6.2",
diff --git a/npm-packages/dashboard/package.json b/npm-packages/dashboard/package.json
@@ -99,7 +99,7 @@
     "eslint-plugin-import": "^2.30.0",
     "eslint-plugin-jsx-a11y": "^6.6.0",
     "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-react": "^7.37.2",
+    "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^4.6.2",
     "jest": "^29.6.0",
     "jest-environment-jsdom": "^29.5.0",
diff --git a/npm-packages/lint/eslint.config.mjs b/npm-packages/lint/eslint.config.mjs
@@ -0,0 +1,179 @@
+import { defineConfig, globalIgnores } from "eslint/config";
+
+import tsParser from "@typescript-eslint/parser";
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import reactHooks from "eslint-plugin-react-hooks";
+import react from "eslint-plugin-react";
+import jest from "eslint-plugin-jest";
+
+import { fixupPluginRules } from "@eslint/compat";
+
+import globals from "globals";
+import js from "@eslint/js";
+
+import { FlatCompat } from "@eslint/eslintrc";
+
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+export default defineConfig([
+  {
+    languageOptions: {
+      parser: tsParser,
+
+      globals: {
+        ...globals.amd,
+        ...globals.browser,
+        ...globals.jest,
+        ...globals.node,
+      },
+    },
+
+    plugins: {
+      "@typescript-eslint": typescriptEslint,
+      "react-hooks": fixupPluginRules(reactHooks),
+      react,
+      jest,
+    },
+
+    extends: compat.extends(
+      "eslint:recommended",
+      "plugin:@typescript-eslint/recommended",
+      "prettier",
+      "plugin:jest/recommended",
+    ),
+
+    rules: {
+      // any is terrible but we use it a lot (even in our public code).
+      "@typescript-eslint/no-explicit-any": "off",
+
+      // asserting that values aren't null is risky but useful.
+      "@typescript-eslint/no-non-null-assertion": "off",
+
+      // Add React hooks rules so we don't misuse them.
+      "react-hooks/rules-of-hooks": "error",
+      "react-hooks/exhaustive-deps": "warn",
+
+      eqeqeq: ["error", "always"],
+
+      // In uncompiled demos we need to demonstrate `require` syntax
+      "@typescript-eslint/no-var-requires": "off",
+
+      // allow (_arg: number) => {}
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          argsIgnorePattern: "^_",
+          varsIgnorePattern: "^_",
+        },
+      ],
+
+      "jest/expect-expect": "off",
+      "jest/no-conditional-expect": "off",
+    },
+  },
+  {
+    rules: {
+      "no-console": "error",
+    },
+    basePath: path.join(__dirname, "..", ".."),
+    ignores: [
+      "**/dont-publish-alpha-as-latest.mjs",
+      "**/version-check.mjs",
+      "npm-packages-private/data/**",
+      "npm-packages-private/postalservice/**",
+      "npm-packages/@convex-dev/codemod/**",
+      "npm-packages/component-tests/**",
+      "npm-packages/convex-analytics/**",
+      "npm-packages/convex-chat-speculative/**",
+      "npm-packages/demos/**",
+      "npm-packages/docs/**",
+      "npm-packages/js-integration-tests/**",
+      "npm-packages/local-store/**",
+      "npm-packages/node-executor/**",
+      "npm-packages/private-demos/**",
+      "npm-packages/publishing-tests/**",
+      "npm-packages/retention-tester/**",
+      "npm-packages/scenario-runner/**",
+      "npm-packages/shared-cursors/**",
+      "npm-packages/simulation/**",
+      "npm-packages/text-importer/**",
+      "npm-packages/udf-runtime/**",
+      "npm-packages/udf-tests/**",
+      "npm-packages/version/**",
+    ],
+  },
+  {
+    files: ["**/*.js", "**/*.cjs"],
+    rules: {
+      "@typescript-eslint/no-require-imports": "off",
+    },
+  },
+  ...["js-integration-tests", "scenario-runner/convex", "udf-tests/convex"].map(
+    (pkg) => ({
+      files: [path.join(pkg, "**/*.ts"), path.join(pkg, "**/*.tsx")],
+      rules: {
+        "@typescript-eslint/no-floating-promises": "error",
+      },
+      languageOptions: {
+        parserOptions: {
+          project: path.join(__dirname, "..", pkg, "tsconfig.json"),
+        },
+      },
+    }),
+  ),
+  globalIgnores([
+    "**/.next/**",
+    "**/.nuxt/**",
+    "**/node_modules",
+    "**/dist",
+    "**/.next",
+    "**/.nuxt",
+    "**/build",
+    "common/deploy",
+    "common/scripts",
+    "common/temp",
+    "convex", // has a similar config, separate so vscode can find it
+    "@convex-dev/react-query", // separate because OSS
+    "@convex-dev/eslint-plugin", // has its own config using different dependencies
+    "@convex-dev/design-system", // has its own config using different dependencies
+    "dashboard", // has its own config using different dependencies
+    "dashboard-common", // has its own config using different dependencies
+    "dashboard-self-hosted", // has its own config using different dependencies
+    "dashboard-storybook", // has its own config using different dependencies
+    "docs/.docusaurus", // auto-generated by Docusaurus
+    "system-udfs/convex", // has its own config using different dependencies
+    "demos/nextjs-pages-router", // has its own config using different dependencies
+    "demos/nextjs-app-router", // has its own config using different dependencies
+    "private-demos/react-native", // has its own config using different dependencies
+    "private-demos/actions", // has its own ESLint
+    "private-demos/npm-showcase", // has its own ESLint and `"@typescript-eslint"`
+    "private-demos/quickstarts/nodejs/script.js", // uses require
+    "private-demos/quickstarts/nextjs-app-dir", // should match Next.js quickstart
+    "private-demos/quickstarts/nextjs-app-dir-14", // should match Next.js quickstart
+    "private-demos/nextjs-app-router-snippets", // should match Next.js quickstart
+    "private-demos/nextjs-15-app", // should match Next.js quickstart
+    "private-demos/nextjs-15-app-clerk", // should match Next.js quickstart
+    "private-demos/quickstarts/sveltekit", // sveltekit linting is annoying to set up
+    "private-demos/quickstarts/remix", // won't have these deps installed
+    "private-demos/quickstarts/vue", // won't have these deps installed
+    "private-demos/snippets", // has its own config
+    "private-demos/tanstack-start", // has its own config
+    "private-demos/tanstack-start-clerk", // has its own config
+    "private-demos/tutorial/src/App.tsx", // tutorial warning will go away once user does tutorial
+    "demos/html/script.js", // uses js-doc
+    "demos/html/browser.bundle.js", // just until we can link to a CDN for this
+    "create-convex/template-*",
+    "convex-ai-chat/esm",
+    "convex-ai-chat/cjs",
+    "**/_generated/**", // auto-generated files
+  ]),
+]);
diff --git a/npm-packages/lint/package.json b/npm-packages/lint/package.json
@@ -0,0 +1,25 @@
+{
+  "name": "lint",
+  "description": "Linting and formatting for the Convex monorepo projects",
+  "version": "0.1.0",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "build": ""
+  },
+  "devDependencies": {
+    "@eslint/compat": "~1.3.0",
+    "@eslint/eslintrc": "^3",
+    "@eslint/js": "~9.34.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
+    "dprint": "0.50.1",
+    "eslint": "^9.37.0",
+    "eslint-config-prettier": "^10.0.0",
+    "eslint-plugin-jest": "~28.14.0",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
+    "globals": "~16.3.0",
+    "prettier": "3.6.2"
+  }
+}
diff --git a/npm-packages/private-demos/deploy-speed-test/package.json b/npm-packages/private-demos/deploy-speed-test/package.json
@@ -14,8 +14,8 @@
   "devDependencies": {
     "@types/react": "^18.0.0",
     "@types/react-dom": "^18.0.0",
-    "@typescript-eslint/eslint-plugin": "^6.7.4",
-    "@typescript-eslint/parser": "^6.7.4",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
     "eslint": "^8.29.0",
     "prettier": "3.6.2",
     "typescript": "~5.0.3"
diff --git a/npm-packages/private-demos/nextjs-15-app-clerk/package.json b/npm-packages/private-demos/nextjs-15-app-clerk/package.json
@@ -15,7 +15,7 @@
     "next": "15.5.2",
     "react": "^19",
     "react-dom": "^19",
-    "eslint-plugin-react-hooks": "^5.1.0-beta-26f2496093-20240514",
+    "eslint-plugin-react-hooks": "^5.2.0",
     "@next/eslint-plugin-next": "~15.1.0"
   },
   "devDependencies": {
diff --git a/npm-packages/private-demos/npm-showcase/package.json b/npm-packages/private-demos/npm-showcase/package.json
@@ -34,7 +34,7 @@
     "@types/pdf-parse": "^1.1.1",
     "@types/react": "^18.0.0",
     "@types/react-dom": "^18.0.0",
-    "@typescript-eslint/eslint-plugin": "^8.45.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
     "@vitejs/plugin-react": "^4.2.1",
     "autoprefixer": "^10.4.13",
     "eslint": "^9.37.0",
diff --git a/npm-packages/private-demos/quickstarts/react-vite-ts/package.json b/npm-packages/private-demos/quickstarts/react-vite-ts/package.json
@@ -19,8 +19,8 @@
   "devDependencies": {
     "@types/react": "^18.2.14",
     "@types/react-dom": "^18.2.6",
-    "@typescript-eslint/eslint-plugin": "^5.61.0",
-    "@typescript-eslint/parser": "^5.61.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
     "@vitejs/plugin-react": "^4.0.1",
     "eslint": "^8.44.0",
     "eslint-plugin-react-hooks": "^4.6.0",
diff --git a/npm-packages/private-demos/quickstarts/remix/package.json b/npm-packages/private-demos/quickstarts/remix/package.json
@@ -33,7 +33,7 @@
     "eslint-import-resolver-typescript": "^4.0.0",
     "eslint-plugin-import": "^2.28.1",
     "eslint-plugin-jsx-a11y": "^6.7.1",
-    "eslint-plugin-react": "^7.33.2",
+    "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^5.0.0",
     "globals": "~16.3.0",
     "typescript": "^5.1.6",
diff --git a/npm-packages/private-demos/quickstarts/sveltekit/package.json b/npm-packages/private-demos/quickstarts/sveltekit/package.json
@@ -19,8 +19,8 @@
 		"@sveltejs/kit": "^2.0.0",
 		"@sveltejs/vite-plugin-svelte": "^6.0.0",
 		"@types/eslint": "^9.0.0",
-		"@typescript-eslint/eslint-plugin": "^7.0.0",
-		"@typescript-eslint/parser": "^7.0.0",
+		"@typescript-eslint/eslint-plugin": "^8.0.0",
+		"@typescript-eslint/parser": "^8.0.0",
 		"eslint": "^8.56.0",
 		"eslint-config-prettier": "^10.0.0",
 		"eslint-plugin-svelte": "^3.0.0",
diff --git a/npm-packages/private-demos/snippets/package.json b/npm-packages/private-demos/snippets/package.json
@@ -18,13 +18,13 @@
     "@eslint/eslintrc": "^3",
     "@eslint/js": "~9.34.0",
     "@faker-js/faker": "^10.0.0",
-    "@typescript-eslint/eslint-plugin": "^6.7.4",
-    "@typescript-eslint/parser": "^6.7.4",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
     "eslint": "^9.37.0",
     "eslint-config-prettier": "^10.0.0",
     "eslint-plugin-jest": "~28.14.0",
-    "eslint-plugin-react": "^7.37.2",
-    "eslint-plugin-react-hooks": "^5.1.0-beta-26f2496093-20240514",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
     "typescript": "~5.0.3",
     "@types/node": "^18.17.0",
     "@types/react": "^18.0.0",
diff --git a/npm-packages/private-demos/static-codegen-ts/package.json b/npm-packages/private-demos/static-codegen-ts/package.json
@@ -19,13 +19,13 @@
     "@eslint/eslintrc": "^3",
     "@eslint/js": "~9.34.0",
     "@faker-js/faker": "^10.0.0",
-    "@typescript-eslint/eslint-plugin": "^6.7.4",
-    "@typescript-eslint/parser": "^6.7.4",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
     "eslint": "^9.37.0",
     "eslint-config-prettier": "^10.0.0",
     "eslint-plugin-jest": "~28.14.0",
-    "eslint-plugin-react": "^7.37.2",
-    "eslint-plugin-react-hooks": "^5.1.0-beta-26f2496093-20240514",
+    "eslint-plugin-react": "^7.37.5",
+    "eslint-plugin-react-hooks": "^5.2.0",
     "typescript": "~5.0.3",
     "@types/node": "^18.17.0",
     "@types/react": "^18.0.0",
diff --git a/npm-packages/private-demos/static-codegen/package.json b/npm-packages/private-demos/static-codegen/package.json
diff --git a/npm-packages/private-demos/tanstack-start/package.json b/npm-packages/private-demos/tanstack-start/package.json
diff --git a/npm-packages/rush.json b/npm-packages/rush.json
diff --git a/npm-packages/scenario-runner/package.json b/npm-packages/scenario-runner/package.json
diff --git a/npm-packages/system-udfs/package.json b/npm-packages/system-udfs/package.json
diff --git a/scripts/package-lock.json b/scripts/package-lock.json
diff --git a/scripts/package.json b/scripts/package.json

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.`
`2`	`2`	`{`
`3`	`3`	`"preferredVersionsHash": "9e868af9e9249b1e68ae3b3da499e674c39e4cdc",`
`4`		`- "packageJsonInjectedDependenciesHash": "1e395ecc0784b479582f69d595d282c4140c95cd"`
	`4`	`+ "packageJsonInjectedDependenciesHash": "510a1c559e55b153de42644845c8e87139272475"`
`5`	`5`	`}`