Skip to content

Commit b97b7ac

Browse files
goffrieConvex, Inc.
authored andcommitted
Stop double-counting the _id field in DeveloperDocument::size() (#42663)
`DeveloperDocument.value` is a ConvexObject that already contains an `_id` field, no need to add the denormalized `id` field. GitOrigin-RevId: 2f8d654552b0e4d80928fb03b3f64514d99e8d57
1 parent ef9b664 commit b97b7ac

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

crates/common/src/document.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ impl DeveloperDocument {
268268
}
269269

270270
pub fn size(&self) -> usize {
271-
self.id.size() + self.value.size()
271+
self.value.size()
272272
}
273273

274274
pub fn to_internal_json(&self) -> JsonValue {

crates/database/src/committer.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1021,13 +1021,12 @@ impl<RT: Runtime> Committer<RT> {
10211021
}
10221022
for validated_write in document_writes {
10231023
let ValidatedDocumentWrite {
1024-
id: document_id,
10251024
write: DocumentWrite { document },
10261025
doc_in_vector_index,
10271026
..
10281027
} = validated_write;
10291028
if let Some(document) = document {
1030-
let document_write_size = document_id.size() + document.size();
1029+
let document_write_size = document.size();
10311030
let tablet_id = document.id().tablet_id;
10321031
let Ok(table_namespace) = table_mapping.tablet_namespace(tablet_id) else {
10331032
continue;

0 commit comments

Comments
 (0)