Properly classify errors from serde deserialization of args (#41612)

Need to classify them at a number of a callsites.

GitOrigin-RevId: 019e9644371096c07dc05a5071890f9475d4c82b

Author: nipunn1313

crates/application/src/api.rs

@@ -59,6 +59,7 @@ use udf::{
     HttpActionResponseStreamer,
 };
 use value::{
+    serialized_args_ext::SerializedArgsExt,
     sha256::Sha256Digest,
     DeveloperDocumentId,
 };

crates/application/src/application_function_runner/mod.rs

@@ -185,6 +185,7 @@ use usage_tracking::{
 use value::{
     id_v6::DeveloperDocumentId,
     identifier::Identifier,
+    serialized_args_ext::SerializedArgsExt,
     JsonPackedValue,
     TableNamespace,
 };

crates/convex/sync_types/src/types.rs

@@ -127,10 +127,6 @@ impl SerializedArgs {
     pub fn from_slice(value: &[u8]) -> Result<Self, serde_json::Error> {
         Ok(Self(serde_json::from_slice(value)?))
     }
-
-    pub fn into_args(self) -> anyhow::Result<Vec<JsonValue>> {
-        Ok(serde_json::from_str(self.0.get())?)
-    }
 }
 
 #[derive(Clone, Debug, Eq, PartialEq, AsRefStr)]

crates/isolate/src/environment/udf/async_syscall.rs

@@ -94,6 +94,7 @@ use udf::{
 use value::{
     heap_size::HeapSize,
     id_v6::DeveloperDocumentId,
+    serialized_args_ext::SerializedArgsExt,
     ConvexArray,
     ConvexObject,
     TableName,

crates/isolate/src/ops/validate_args.rs

@@ -8,7 +8,10 @@ use serde_json::{
     json,
     Value as JsonValue,
 };
-use value::ConvexArray;
+use value::{
+    serialized_args_ext::SerializedArgsExt,
+    ConvexArray,
+};
 
 use super::OpProvider;
 use crate::helpers::UdfArgsJson;

crates/isolate/src/test_helpers.rs

@@ -151,6 +151,7 @@ use udf::{
 use usage_tracking::FunctionUsageStats;
 use value::{
     id_v6::DeveloperDocumentId,
+    serialized_args_ext::SerializedArgsExt,
     ConvexArray,
     ConvexObject,
     TableName,

crates/local_backend/src/dashboard.rs

@@ -44,6 +44,7 @@ use serde_json::json;
 use utoipa::ToSchema;
 use utoipa_axum::router::OpenApiRouter;
 use value::{
+    serialized_args_ext::SerializedArgsExt,
     TableName,
     TableNamespace,
 };

crates/local_backend/src/node_action_callbacks.rs

@@ -65,6 +65,7 @@ use usage_tracking::FunctionUsageTracker;
 use value::{
     export::ValueFormat,
     id_v6::DeveloperDocumentId,
+    serialized_args_ext::SerializedArgsExt,
 };
 use vector::{
     VectorSearch,

crates/value/src/lib.rs

@@ -22,6 +22,7 @@ mod metrics;
 pub mod numeric;
 mod object;
 pub mod serde;
+pub mod serialized_args_ext;
 mod set;
 pub mod sha256;
 mod size;

crates/value/src/serialized_args_ext.rs

@@ -0,0 +1,17 @@
+use anyhow::Context;
+use errors::ErrorMetadata;
+use serde_json::Value as JsonValue;
+use sync_types::types::SerializedArgs;
+
+pub trait SerializedArgsExt {
+    fn into_args(self) -> anyhow::Result<Vec<JsonValue>>;
+}
+
+impl SerializedArgsExt for SerializedArgs {
+    fn into_args(self) -> anyhow::Result<Vec<JsonValue>> {
+        serde_json::from_str(self.0.get()).context(ErrorMetadata::bad_request(
+            "InvalidArguments",
+            "Invalid arguments provided",
+        ))
+    }
+}