Fix framework detection of TanStack Start + Vite (#42464)

Modern TanStack Start projects use Vite, so we should try to detect TanStack Start before detecting Vite.

GitOrigin-RevId: eba91feef08a4206ffbe8fc9e4902e79c96b23d7

Author: Nicolapps

npm-packages/convex/src/cli/lib/envvars.ts

@@ -158,27 +158,28 @@ export async function suggestedEnvVarName(ctx: Context): Promise<{
     };
   }
 
-  // Vite is a dependency of a lot of things; vite appearing in dependencies is not a strong indicator.
-  const isVite = "vite" in packages;
+  // TanStackStart currently supports VITE_FOO for browser-side envvars.
+  const isTanStackStart =
+    "@tanstack/start" in packages || "@tanstack/react-start" in packages;
 
-  if (isVite) {
+  if (isTanStackStart) {
     return {
-      detectedFramework: "Vite",
+      detectedFramework: "TanStackStart",
       envVar: "VITE_CONVEX_URL",
-      frontendDevUrl: "http://localhost:5173",
+      frontendDevUrl: "http://localhost:3000",
       publicPrefix: "VITE_",
     };
   }
 
-  // TanStackStart currently supports VITE_FOO for browser-side envvars.
-  const isTanStackStart =
-    "@tanstack/start" in packages || "@tanstack/react-start" in packages;
+  // Vite is a dependency of a lot of things; vite appearing in dependencies is not a strong indicator.
+  const isVite = "vite" in packages;
 
-  if (isTanStackStart) {
+  if (isVite) {
     return {
-      detectedFramework: "TanStackStart",
+      detectedFramework: "Vite",
       envVar: "VITE_CONVEX_URL",
-      frontendDevUrl: "http://localhost:3000",
+      frontendDevUrl: "http://localhost:5173",
+      publicPrefix: "VITE_",
     };
   }