Skip to content

Commit 505cbf1

Browse files
authored
Use PUBLIC scope for dependencies (#256)
1 parent 36261b4 commit 505cbf1

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ if (REFLECTCPP_USE_BUNDLED_DEPENDENCIES)
7575
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include/rfl/thirdparty>)
7676
else ()
7777
find_package(ctre CONFIG REQUIRED)
78-
target_link_libraries(reflectcpp INTERFACE ctre::ctre)
78+
target_link_libraries(reflectcpp PUBLIC ctre::ctre)
7979
endif ()
8080

8181
if (REFLECTCPP_JSON)
@@ -93,7 +93,7 @@ if (REFLECTCPP_JSON)
9393
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include/rfl/thirdparty>)
9494
else ()
9595
find_package(yyjson CONFIG REQUIRED)
96-
target_link_libraries(reflectcpp INTERFACE yyjson::yyjson)
96+
target_link_libraries(reflectcpp PUBLIC yyjson::yyjson)
9797
endif ()
9898
endif ()
9999

@@ -123,7 +123,7 @@ if (REFLECTCPP_FLEXBUFFERS)
123123
src/reflectcpp_flexbuf.cpp
124124
)
125125
find_package(flatbuffers CONFIG REQUIRED)
126-
target_link_libraries(reflectcpp INTERFACE flatbuffers::flatbuffers)
126+
target_link_libraries(reflectcpp PUBLIC flatbuffers::flatbuffers)
127127
endif ()
128128

129129
if (REFLECTCPP_MSGPACK)
@@ -163,15 +163,15 @@ if (REFLECTCPP_XML)
163163
src/reflectcpp_xml.cpp
164164
)
165165
find_package(pugixml CONFIG REQUIRED)
166-
target_link_libraries(reflectcpp INTERFACE pugixml::pugixml)
166+
target_link_libraries(reflectcpp PUBLIC pugixml::pugixml)
167167
endif ()
168168

169169
if (REFLECTCPP_YAML)
170170
list(APPEND REFLECT_CPP_SOURCES
171171
src/reflectcpp_yaml.cpp
172172
)
173173
find_package(yaml-cpp CONFIG REQUIRED)
174-
target_link_libraries(reflectcpp INTERFACE yaml-cpp::yaml-cpp)
174+
target_link_libraries(reflectcpp PUBLIC yaml-cpp::yaml-cpp)
175175
endif ()
176176

177177
set_target_properties(reflectcpp PROPERTIES LINKER_LANGUAGE CXX)
@@ -188,7 +188,7 @@ endif ()
188188
if (REFLECTCPP_BUILD_BENCHMARKS)
189189
find_package(benchmark CONFIG REQUIRED)
190190
find_package(simdjson CONFIG REQUIRED)
191-
target_link_libraries(reflectcpp INTERFACE benchmark::benchmark simdjson::simdjson)
191+
target_link_libraries(reflectcpp PUBLIC benchmark::benchmark simdjson::simdjson)
192192
add_subdirectory(benchmarks)
193193
endif ()
194194

0 commit comments

Comments
 (0)