Treat any span with remote parent as a transaction

Author: solnic

lib/sentry/opentelemetry/span_processor.ex

@@ -22,52 +22,35 @@ if Sentry.OpenTelemetry.VersionChecker.tracing_compatible?() do
 
     @impl :otel_span_processor
     def on_start(_ctx, otel_span, _config) do
+      span_record = SpanRecord.new(otel_span)
+      SpanStorage.store_span(span_record)
       otel_span
     end
 
     @impl :otel_span_processor
     def on_end(otel_span, _config) do
       span_record = SpanRecord.new(otel_span)
-      process_span(span_record)
-    end
-
-    defp process_span(span_record) do
-      SpanStorage.store_span(span_record)
-
-      # Check if this is a root span (no parent) or a transaction root
-      #
-      # A span should be a transaction root if:
-      # 1. It has no parent (true root span)
-      # 2. OR it's a server span with only a REMOTE parent (distributed tracing)
-      #
-      # A span should NOT be a transaction root if:
-      # - It has a LOCAL parent (parent span exists in our SpanStorage)
-      is_transaction_root =
-        cond do
-          # No parent = definitely a root
-          span_record.parent_span_id == nil ->
-            true
-
-          # Has a parent - check if it's local or remote
-          true ->
-            has_local_parent = has_local_parent_span?(span_record.parent_span_id)
-
-            if has_local_parent do
-              # Parent exists locally - this is a child span, not a transaction root
-              false
-            else
-              # Parent is remote (distributed tracing) - treat server spans as transaction roots
-              is_server_span?(span_record)
-            end
-        end
+      SpanStorage.update_span(span_record)
 
-      if is_transaction_root do
+      if is_transaction_root?(span_record) do
         build_and_send_transaction(span_record)
       else
         true
       end
     end
 
+    # Check if this is a root span (no parent) or a transaction root
+    #
+    # A span should be a transaction root if:
+    #
+    # 1. It has no parent (true root span)
+    # 2. OR it's a span with a remote parent span
+    #
+    defp is_transaction_root?(span_record) do
+      span_record.parent_span_id == nil or
+        not SpanStorage.span_exists?(span_record.parent_span_id)
+    end
+
     defp build_and_send_transaction(span_record) do
       child_span_records = SpanStorage.get_child_spans(span_record.span_id)
       transaction = build_transaction(span_record, child_span_records)
@@ -99,22 +82,6 @@ if Sentry.OpenTelemetry.VersionChecker.tracing_compatible?() do
       :ok
     end
 
-    # Checks if a parent span exists in our local SpanStorage
-    # This helps distinguish between:
-    # - Local parents: span exists in storage (same service)
-    # - Remote parents: span doesn't exist in storage (distributed tracing from another service)
-    defp has_local_parent_span?(parent_span_id) do
-      SpanStorage.span_exists?(parent_span_id)
-    end
-
-    # Helper function to detect if a span is a server span that should be
-    # treated as a transaction root for distributed tracing.
-    defp is_server_span?(%{kind: :server, attributes: attributes}) do
-      Map.has_key?(attributes, to_string(HTTPAttributes.http_request_method()))
-    end
-
-    defp is_server_span?(_), do: false
-
     defp build_transaction(root_span_record, child_span_records) do
       root_span = build_span(root_span_record)
       child_spans = Enum.map(child_span_records, &build_span(&1))