Skip to content

Commit 01ee818

Browse files
onurtemizkans1gr1d
andcommitted
Apply suggestions from code review
Co-authored-by: Sigrid Huemer <32902192+s1gr1d@users.noreply.github.com>
1 parent e25699c commit 01ee818

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/node/src/integrations/tracing/firebase/otel/patches/firestore.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,8 @@ export function patchFirestore(
5151
config: FirebaseInstrumentationConfig,
5252
): InstrumentationNodeModuleDefinition {
5353
// eslint-disable-next-line @typescript-eslint/no-empty-function
54-
const defaultFirestoreSpanCreationHook: FirestoreSpanCreationHook = () => {};
55-
56-
let firestoreSpanCreationHook: FirestoreSpanCreationHook = defaultFirestoreSpanCreationHook;
54+
// Setting an empty function as a default
55+
let firestoreSpanCreationHook: FirestoreSpanCreationHook = () => {};
5756
const configFirestoreSpanCreationHook = config.firestoreSpanCreationHook;
5857

5958
if (typeof configFirestoreSpanCreationHook === 'function') {

packages/node/src/integrations/tracing/firebase/otel/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export interface DocumentReference<T = DocumentData, U extends DocumentData = Do
4646
settings: FirestoreSettings;
4747
};
4848
};
49-
type: string; // 'collection' or 'document'
49+
type: 'collection' | 'document' | string;
5050
path: string;
5151
parent: CollectionReference<T, U>;
5252
}

0 commit comments

Comments
 (0)