From 7577a17161be29ab9953152e8e39391b6e488e3e Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Tue, 14 Oct 2025 15:58:47 +0200 Subject: [PATCH 1/4] Use non-experimental enableLogs --- packages/core/ios/RNSentryExperimentalOptions.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/ios/RNSentryExperimentalOptions.m b/packages/core/ios/RNSentryExperimentalOptions.m index 2e7db99a71..960c52db0d 100644 --- a/packages/core/ios/RNSentryExperimentalOptions.m +++ b/packages/core/ios/RNSentryExperimentalOptions.m @@ -24,7 +24,7 @@ + (void)setEnableLogs:(BOOL)enabled sentryOptions:(SentryOptions *)sentryOptions if (sentryOptions == nil) { return; } - sentryOptions.experimental.enableLogs = enabled; + sentryOptions.enableLogs = enabled; } @end From d3fe30631d01812ce380ff86ca536a44cfb23717 Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Tue, 14 Oct 2025 16:26:20 +0200 Subject: [PATCH 2/4] bump target --- .../RNSentryCocoaTester.xcodeproj/project.pbxproj | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj b/packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj index 1c99c3a801..02284f6023 100644 --- a/packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj +++ b/packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj @@ -236,10 +236,14 @@ inputFileListPaths = ( "${PODS_ROOT}/Target Support Files/Pods-RNSentryCocoaTesterTests/Pods-RNSentryCocoaTesterTests-resources-${CONFIGURATION}-input-files.xcfilelist", ); + inputPaths = ( + ); name = "[CP] Copy Pods Resources"; outputFileListPaths = ( "${PODS_ROOT}/Target Support Files/Pods-RNSentryCocoaTesterTests/Pods-RNSentryCocoaTesterTests-resources-${CONFIGURATION}-output-files.xcfilelist", ); + outputPaths = ( + ); runOnlyForDeploymentPostprocessing = 0; shellPath = /bin/sh; shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-RNSentryCocoaTesterTests/Pods-RNSentryCocoaTesterTests-resources.sh\"\n"; @@ -434,7 +438,7 @@ "\"$(PODS_TARGET_SRCROOT)/include/\"", "\"${PODS_ROOT}/Sentry/Sources/Sentry/include\"", ); - IPHONEOS_DEPLOYMENT_TARGET = 12.4; + IPHONEOS_DEPLOYMENT_TARGET = 15.0; MARKETING_VERSION = 1.0; PRODUCT_BUNDLE_IDENTIFIER = io.sentry.RNSentryCocoaTesterTests; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -501,7 +505,7 @@ "\"$(PODS_TARGET_SRCROOT)/include/\"", "\"${PODS_ROOT}/Sentry/Sources/Sentry/include\"", ); - IPHONEOS_DEPLOYMENT_TARGET = 12.4; + IPHONEOS_DEPLOYMENT_TARGET = 15.0; MARKETING_VERSION = 1.0; PRODUCT_BUNDLE_IDENTIFIER = io.sentry.RNSentryCocoaTesterTests; PRODUCT_NAME = "$(TARGET_NAME)"; From 3bd04c2aaa7b5ac6aa5fa8c78aedefa2e27ae469 Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Tue, 14 Oct 2025 16:52:51 +0200 Subject: [PATCH 3/4] remove enable tracing --- .../RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m b/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m index 4c9a9d1e04..5be4d2bdec 100644 --- a/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m +++ b/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m @@ -36,7 +36,6 @@ - (void)testCreateOptionsWithDictionaryRemovesPerformanceProperties XCTAssertEqual( actualOptions.tracesSampleRate, nil, @"Traces sample rate should not be passed to native"); XCTAssertEqual(actualOptions.tracesSampler, nil, @"Traces sampler should not be passed to native"); -XCTAssertEqual(actualOptions.enableTracing, false, @"EnableTracing should not be passed to native"); } - (void)testCaptureFailedRequestsIsDisabled From cc596a89489fa246af64c4a87d2e14df2341c574 Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Wed, 15 Oct 2025 10:18:38 +0200 Subject: [PATCH 4/4] Update enableLogs tests --- .../RNSentryCocoaTesterTests/RNSentryTests.m | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m b/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m index 5be4d2bdec..66556e6e27 100644 --- a/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m +++ b/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m @@ -330,10 +330,7 @@ - (void)testCreateOptionsWithDictionaryEnableLogsEnabled XCTAssertNotNil(actualOptions, @"Did not create sentry options"); XCTAssertNil(error, @"Should not pass no error"); - id experimentalOptions = [actualOptions valueForKey:@"experimental"]; - XCTAssertNotNil(experimentalOptions, @"Experimental options should not be nil"); - - BOOL enableLogs = [[experimentalOptions valueForKey:@"enableLogs"] boolValue]; + BOOL enableLogs = [[actualOptions valueForKey:@"enableLogs"] boolValue]; XCTAssertTrue(enableLogs, @"enableLogs should be enabled"); } @@ -351,11 +348,8 @@ - (void)testCreateOptionsWithDictionaryEnableLogsDisabled XCTAssertNotNil(actualOptions, @"Did not create sentry options"); XCTAssertNil(error, @"Should not pass no error"); - - id experimentalOptions = [actualOptions valueForKey:@"experimental"]; - XCTAssertNotNil(experimentalOptions, @"Experimental options should not be nil"); - - BOOL enableLogs = [[experimentalOptions valueForKey:@"enableLogs"] boolValue]; + + BOOL enableLogs = [[actualOptions valueForKey:@"enableLogs"] boolValue]; XCTAssertFalse(enableLogs, @"enableLogs should be disabled"); }