Removes title from linked issues payload, adds date_added

Author: GabeVillalobos

src/sentry/issues/services/issue/impl.py

@@ -6,6 +6,7 @@
 
 from sentry.integrations.models.external_issue import ExternalIssue
 from sentry.issues.services.issue.model import RpcGroupShareMetadata, RpcLinkedIssueSummary
+from sentry.issues.services.issue.serial import serialize_linked_issue_summary
 from sentry.issues.services.issue.service import IssueService
 from sentry.models.group import Group
 from sentry.models.organization import Organization
@@ -65,6 +66,5 @@ def get_linked_issues(
         ).order_by("date_added")
 
         return [
-            RpcLinkedIssueSummary.from_external_issue(external_issue)
-            for external_issue in external_issues
+            serialize_linked_issue_summary(external_issue) for external_issue in external_issues
         ]

src/sentry/issues/services/issue/model.py

@@ -1,8 +1,8 @@
 from __future__ import annotations
 
+from datetime import datetime
+
 from sentry.hybridcloud.rpc import RpcModel
-from sentry.integrations.models.external_issue import ExternalIssue
-from sentry.models.grouplink import GroupLink
 
 
 class RpcGroupShareMetadata(RpcModel):
@@ -11,20 +11,5 @@ class RpcGroupShareMetadata(RpcModel):
 
 
 class RpcLinkedIssueSummary(RpcModel):
-    title: str
     issue_link: str
-
-    @classmethod
-    def from_external_issue(cls, external_issue: ExternalIssue) -> RpcLinkedIssueSummary:
-        group_link = GroupLink.objects.get(
-            linked_id=external_issue.id,
-            linked_type=GroupLink.LinkedType.issue,
-            relationship=GroupLink.Relationship.references,
-        )
-
-        group_url = group_link.group.get_absolute_url()
-
-        return RpcLinkedIssueSummary(
-            title=external_issue.title or "",
-            issue_link=group_url,
-        )
+    date_added: datetime

tests/sentry/issues/services/test_issue_service.py

@@ -85,12 +85,11 @@ def create_linked_issue(
 
     def test_get_linked_issues(self):
         group = self.create_group(project=self.us_region_context.project)
-        self.create_linked_issue(
+        linked_issue = self.create_linked_issue(
             key="TEST-123",
             region_context=self.us_region_context,
             group=group,
             integration=self.default_jira_integration,
-            title="US Group Link",
         )
 
         response = issue_service.get_linked_issues(
@@ -103,7 +102,7 @@ def test_get_linked_issues(self):
         assert response == [
             RpcLinkedIssueSummary(
                 issue_link=group.get_absolute_url(),
-                title=group.title,
+                date_added=linked_issue.date_added,
             )
         ]
 
@@ -114,7 +113,6 @@ def test_get_linked_issues_with_multiple_organizations_in_multiple_regions(self)
             region_context=self.us_region_context,
             group=us_group,
             integration=self.default_jira_integration,
-            title="US Group Link",
         )
 
         de_group = self.create_group(project=self.de_region_context.project)
@@ -123,7 +121,6 @@ def test_get_linked_issues_with_multiple_organizations_in_multiple_regions(self)
             region_context=self.de_region_context,
             group=de_group,
             integration=self.default_jira_integration,
-            title="DE Group Link",
         )
 
         response = issue_service.get_linked_issues(
@@ -139,11 +136,11 @@ def test_get_linked_issues_with_multiple_organizations_in_multiple_regions(self)
         assert response == [
             RpcLinkedIssueSummary(
                 issue_link=us_group.get_absolute_url(),
-                title=us_linked_issue.title,
+                date_added=us_linked_issue.date_added,
             ),
             RpcLinkedIssueSummary(
                 issue_link=de_group.get_absolute_url(),
-                title=de_linked_issue.title,
+                date_added=de_linked_issue.date_added,
             ),
         ]
 
@@ -159,12 +156,11 @@ def test_get_empty_response_when_no_linked_issues(self):
 
     def test_get_single_linked_issue_when_multiple_organizations_share_integration(self):
         us_group = self.create_group(project=self.us_region_context.project)
-        us_linked_issue = self.create_linked_issue(
+        linked_issue = self.create_linked_issue(
             key="TEST-123",
             region_context=self.us_region_context,
             group=us_group,
             integration=self.default_jira_integration,
-            title="US Group Link",
         )
 
         response = issue_service.get_linked_issues(
@@ -177,7 +173,7 @@ def test_get_single_linked_issue_when_multiple_organizations_share_integration(s
         assert response == [
             RpcLinkedIssueSummary(
                 issue_link=us_group.get_absolute_url(),
-                title=us_linked_issue.title,
+                date_added=linked_issue.date_added,
             )
         ]
 
@@ -188,7 +184,6 @@ def test_filters_out_issues_from_other_organizations(self):
             region_context=self.us_region_context,
             group=us_group,
             integration=self.default_jira_integration,
-            title="US Group Link",
         )
 
         other_integration = self.create_integration(
@@ -205,7 +200,6 @@ def test_filters_out_issues_from_other_organizations(self):
             region_context=self.us_region_context,
             group=unrelated_us_group,
             integration=other_integration,
-            title="Unrelated US Group Link",
         )
 
         response = issue_service.get_linked_issues(
@@ -218,6 +212,6 @@ def test_filters_out_issues_from_other_organizations(self):
         assert response == [
             RpcLinkedIssueSummary(
                 issue_link=us_group.get_absolute_url(),
-                title=us_linked_issue.title,
+                date_added=us_linked_issue.date_added,
             )
         ]