ref(uptime): Remove unused uptimeSubscriptionId from serializer (#96672)

Author: evanpurkhiser

src/sentry/uptime/endpoints/project_uptime_alert_checks_index.py

@@ -353,7 +353,7 @@ def _transform_row(
 
         return EapCheckEntry(
             uptime_check_id=uptime_check_id,
-            uptime_subscription_id=uptime_subscription.id,
+            uptime_monitor_id=uptime_subscription.id,
             timestamp=datetime.fromtimestamp(row_dict["timestamp"].val_double),
             scheduled_check_time=scheduled_check_time,
             check_status=cast(CheckStatus, row_dict["check_status"].val_str),

src/sentry/uptime/endpoints/serializers.py

@@ -104,7 +104,6 @@ def serialize(
 
 class EapCheckEntrySerializerResponse(TypedDict):
     uptimeCheckId: str
-    uptimeSubscriptionId: int
     projectUptimeSubscriptionId: int
     timestamp: str
     scheduledCheckTime: str
@@ -137,8 +136,7 @@ def serialize(
 
         return {
             "uptimeCheckId": obj.uptime_check_id,
-            "uptimeSubscriptionId": obj.uptime_subscription_id,
-            "projectUptimeSubscriptionId": obj.uptime_subscription_id,
+            "projectUptimeSubscriptionId": obj.uptime_monitor_id,
             "timestamp": obj.timestamp.strftime("%Y-%m-%dT%H:%M:%SZ"),
             "scheduledCheckTime": obj.scheduled_check_time.strftime("%Y-%m-%dT%H:%M:%SZ"),
             "checkStatus": check_status,

src/sentry/uptime/types.py

@@ -112,7 +112,7 @@ class EapCheckEntry:
     """
 
     uptime_check_id: str
-    uptime_subscription_id: int
+    uptime_monitor_id: int
     timestamp: datetime
     scheduled_check_time: datetime
     check_status: CheckStatus

tests/sentry/uptime/endpoints/test_project_uptime_alert_check_index.py

@@ -77,7 +77,7 @@ def test_get(self) -> None:
             assert len(response.data) == 6
             most_recent = response.data[0]
             for key in [
-                "uptimeSubscriptionId",
+                "projectUptimeSubscriptionId",
                 "uptimeCheckId",
                 "scheduledCheckTime",
                 "timestamp",
@@ -93,7 +93,7 @@ def test_get(self) -> None:
                 assert key in most_recent, f"{key} not in {most_recent}"
 
             assert most_recent["uptimeCheckId"]
-            assert most_recent["uptimeSubscriptionId"] == self.project_uptime_subscription.id
+            assert most_recent["projectUptimeSubscriptionId"] == self.project_uptime_subscription.id
             assert most_recent["regionName"] == "Default Region"
             assert most_recent["checkStatusReason"] == "failure"