Skip to content

Commit 3a9a741

Browse files
committed
Fix
1 parent 0e88aeb commit 3a9a741

File tree

2 files changed

+33
-8
lines changed

2 files changed

+33
-8
lines changed

static/app/views/preprod/buildComparison/main/sizeCompareSelectionContent.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import useOrganization from 'sentry/utils/useOrganization';
3535
import {useParams} from 'sentry/utils/useParams';
3636
import {
3737
BuildDetailsState,
38+
getPrimarySizeMetric,
3839
isSizeInfoCompleted,
3940
type BuildDetailsApiResponse,
4041
} from 'sentry/views/preprod/types/buildDetailsTypes';
@@ -249,13 +250,21 @@ function BuildItem({build, isSelected, onSelect}: BuildItemProps) {
249250
{isSizeInfoCompleted(sizeInfo) && (
250251
<Flex align="center" gap="sm">
251252
<IconCode size="xs" color="gray300" />
252-
<Text>{formatBytesBase10(sizeInfo.install_size_bytes)}</Text>
253+
<Text>
254+
{formatBytesBase10(
255+
getPrimarySizeMetric(sizeInfo)?.install_size_bytes ?? 0
256+
)}
257+
</Text>
253258
</Flex>
254259
)}
255260
{isSizeInfoCompleted(sizeInfo) && (
256261
<Flex align="center" gap="sm">
257262
<IconDownload size="xs" color="gray300" />
258-
<Text>{formatBytesBase10(sizeInfo.download_size_bytes)}</Text>
263+
<Text>
264+
{formatBytesBase10(
265+
getPrimarySizeMetric(sizeInfo)?.download_size_bytes ?? 0
266+
)}
267+
</Text>
259268
</Flex>
260269
)}
261270
</Flex>

static/app/views/preprod/buildDetails/buildDetails.spec.tsx

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66

77
import {render, screen, waitFor} from 'sentry-test/reactTestingLibrary';
88

9+
import {MetricsArtifactType} from 'sentry/views/preprod/types/appSizeTypes';
910
import {BuildDetailsSizeAnalysisState} from 'sentry/views/preprod/types/buildDetailsTypes';
1011

1112
import BuildDetails from './buildDetails';
@@ -98,8 +99,13 @@ describe('BuildDetails', () => {
9899
body: PreprodBuildDetailsWithSizeInfoFixture(
99100
{
100101
state: BuildDetailsSizeAnalysisState.COMPLETED,
101-
install_size_bytes: 1024000,
102-
download_size_bytes: 512000,
102+
size_metrics: [
103+
{
104+
metrics_artifact_type: MetricsArtifactType.MAIN_ARTIFACT,
105+
install_size_bytes: 1024000,
106+
download_size_bytes: 512000,
107+
},
108+
],
103109
},
104110
{
105111
vcs_info: PreprodVcsInfoFullFixture(),
@@ -168,8 +174,13 @@ describe('BuildDetails', () => {
168174
}
169175
return PreprodBuildDetailsWithSizeInfoFixture({
170176
state: BuildDetailsSizeAnalysisState.COMPLETED,
171-
install_size_bytes: 1024000,
172-
download_size_bytes: 512000,
177+
size_metrics: [
178+
{
179+
metrics_artifact_type: MetricsArtifactType.MAIN_ARTIFACT,
180+
install_size_bytes: 1024000,
181+
download_size_bytes: 512000,
182+
},
183+
],
173184
});
174185
},
175186
});
@@ -215,8 +226,13 @@ describe('BuildDetails', () => {
215226
method: 'GET',
216227
body: PreprodBuildDetailsWithSizeInfoFixture({
217228
state: BuildDetailsSizeAnalysisState.COMPLETED,
218-
install_size_bytes: 1024000,
219-
download_size_bytes: 512000,
229+
size_metrics: [
230+
{
231+
metrics_artifact_type: MetricsArtifactType.MAIN_ARTIFACT,
232+
install_size_bytes: 1024000,
233+
download_size_bytes: 512000,
234+
},
235+
],
220236
}),
221237
});
222238

0 commit comments

Comments
 (0)