fix(feedback): parse JSON after checking status code (#103167)

fixes a bunch of noisy `JSONDecodeErrors` in title gen, label gen, and
spam detection that were happening because we tried to JSON decode 500
responses:

https://sentry.sentry.io/issues/6977994202/?query=%22jsondecodeerror%22&referrer=issue-stream

https://sentry.sentry.io/issues/6978011530/?query=%22jsondecodeerror%22&referrer=issue-stream

https://sentry.sentry.io/issues/6978011522/?query=%22jsondecodeerror%22&referrer=issue-stream

https://sentry.sentry.io/issues/6978011504/?query=%22jsondecodeerror%22&referrer=issue-stream

`response.json()` calls are now outside try/catch which SHOULD be safe
because by the time we get here, the status code is 200. This pattern
matches what's currently in
[`organization_feedback_summary.py`](https://github.com/getsentry/sentry/blob/b91b6e10dd3812b081ca3b317b8923bca709e796/src/sentry/feedback/endpoints/organization_feedback_summary.py#L64).

Author: srest2021

src/sentry/feedback/endpoints/organization_feedback_categories.py

@@ -219,7 +219,6 @@ def get(self, request: Request, organization: Organization) -> Response:
                     timeout=SEER_TIMEOUT_S,
                     retries=SEER_RETRIES,
                 )
-                response_data = response.json()
             except Exception:
                 logger.exception("Seer failed to generate user feedback label groups")
                 return Response(
@@ -233,7 +232,7 @@ def get(self, request: Request, organization: Organization) -> Response:
                 return Response(
                     {"detail": "Failed to generate user feedback label groups"}, status=500
                 )
-            label_groups = response_data["data"]
+            label_groups = response.json()["data"]
         else:
             # If there are less than THRESHOLD_TO_GET_ASSOCIATED_LABELS feedbacks, we don't ask for associated labels
             # The more feedbacks there are, the LLM does a better job of generating associated labels since it has more context

src/sentry/feedback/usecases/label_generation.py

@@ -46,7 +46,6 @@ def generate_labels(feedback_message: str, organization_id: int) -> list[str]:
             timeout=SEER_TIMEOUT_S,
             retries=SEER_RETRIES,
         )
-        response_data = response.json()
     except Exception:
         logger.exception("Seer failed to generate user feedback labels")
         raise
@@ -58,7 +57,5 @@ def generate_labels(feedback_message: str, organization_id: int) -> list[str]:
         )
         raise Exception("Seer returned non-200 response")
 
-    labels = response_data["data"]["labels"]
-
     # Guaranteed to be a list of strings (validated in Seer)
-    return labels
+    return response.json()["data"]["labels"]

src/sentry/feedback/usecases/spam_detection.py

@@ -35,7 +35,6 @@ def is_spam_seer(message: str, organization_id: int) -> bool | None:
             timeout=SEER_TIMEOUT_S,
             retries=SEER_RETRIES,
         )
-        response_data = response.json()
     except Exception:
         logger.exception("Seer failed to check if message is spam")
         return None
@@ -47,6 +46,7 @@ def is_spam_seer(message: str, organization_id: int) -> bool | None:
         )
         return None
 
+    response_data = response.json()
     if (
         not isinstance(response_data, dict)
         or "is_spam" not in response_data

src/sentry/feedback/usecases/title_generation.py

@@ -77,7 +77,6 @@ def get_feedback_title_from_seer(feedback_message: str, organization_id: int) ->
             timeout=SEER_TIMEOUT_S,
             retries=SEER_RETRIES,
         )
-        response_data = response.json()
     except Exception:
         return None
 
@@ -93,7 +92,7 @@ def get_feedback_title_from_seer(feedback_message: str, organization_id: int) ->
         return None
 
     try:
-        return response_data["title"].strip() or None
+        return response.json()["title"].strip() or None
     except Exception:
         return None