use enums

Author: lobsterkatie

src/sentry/interfaces/stacktrace.py

@@ -100,9 +100,9 @@ def is_newest_frame_first(event):
             filter=dict(user_ids=[env.request.user.id], keys=["stacktrace_order"])
         )
         display = get_option_from_list(options, default=None)
-        if display == "1":
+        if display == StacktraceOrder.MOST_RECENT_LAST:
             newest_first = False
-        elif display == "2":
+        elif display == StacktraceOrder.MOST_RECENT_FIRST:
             newest_first = True
 
     return newest_first

src/sentry/users/api/serializers/user.py

@@ -16,6 +16,7 @@
 from sentry.app import env
 from sentry.auth.elevated_mode import has_elevated_mode
 from sentry.hybridcloud.services.organization_mapping import organization_mapping_service
+from sentry.interfaces.stacktrace import StacktraceOrder
 from sentry.models.authidentity import AuthIdentity
 from sentry.models.organization import OrganizationStatus
 from sentry.models.organizationmapping import OrganizationMapping
@@ -67,7 +68,7 @@ class _SerializedStacktraceOrder(int, Enum):
 class _UserOptions(TypedDict):
     theme: str  # TODO: enum/literal for theme options
     language: str
-    stacktraceOrder: int  # TODO: enum/literal
+    stacktraceOrder: _SerializedStacktraceOrder
     defaultIssueEvent: str
     timezone: str
     clock24Hours: bool
@@ -198,7 +199,13 @@ def serialize(
                 for o in UserOption.objects.filter(user_id=user.id, project_id__isnull=True)
                 if o.value is not None
             }
-            stacktrace_order = int(options.get("stacktrace_order", -1) or -1)
+
+            stacktrace_order = _SerializedStacktraceOrder(
+                int(
+                    options.get("stacktrace_order", StacktraceOrder.DEFAULT)
+                    or StacktraceOrder.DEFAULT
+                )
+            )
 
             d["options"] = {
                 "theme": options.get("theme") or "light",

src/sentry/users/models/user_option.py

@@ -185,7 +185,7 @@ class UserOption(Model):
      - self_notifications
         - "Notify Me About My Own Activity"
      - stacktrace_order
-        - default, most recent first, most recent last
+        - default, most recent first, most recent last (see `StacktraceOrder` enum)
      - subscribe_by_default
         - "Only On Issues I Subscribe To", "Only On Deploys With My Commits"
      - subscribe_notes

tests/sentry/users/api/endpoints/test_user_details.py

@@ -2,6 +2,7 @@
 from pytest import fixture
 
 from sentry.deletions.tasks.hybrid_cloud import schedule_hybrid_cloud_foreign_key_jobs
+from sentry.interfaces.stacktrace import StacktraceOrder
 from sentry.models.deletedorganization import DeletedOrganization
 from sentry.models.organization import Organization, OrganizationStatus
 from sentry.models.organizationmember import OrganizationMember
@@ -43,7 +44,7 @@ def test_lookup_self(self) -> None:
         assert resp.data["options"]["defaultIssueEvent"] == "recommended"
         assert resp.data["options"]["timezone"] == "UTC"
         assert resp.data["options"]["language"] == "en"
-        assert resp.data["options"]["stacktraceOrder"] == -1
+        assert resp.data["options"]["stacktraceOrder"] == int(StacktraceOrder.DEFAULT)
         assert not resp.data["options"]["clock24Hours"]
         assert not resp.data["options"]["prefersIssueDetailsStreamlinedUI"]
         assert not resp.data["options"]["prefersStackedNavigation"]
@@ -113,7 +114,7 @@ def test_simple(self) -> None:
                 "theme": "system",
                 "defaultIssueEvent": "latest",
                 "timezone": "UTC",
-                "stacktraceOrder": "2",
+                "stacktraceOrder": StacktraceOrder.MOST_RECENT_FIRST,
                 "language": "fr",
                 "clock24Hours": True,
                 "extra": True,
@@ -135,7 +136,10 @@ def test_simple(self) -> None:
         assert UserOption.objects.get_value(user=self.user, key="theme") == "system"
         assert UserOption.objects.get_value(user=self.user, key="default_issue_event") == "latest"
         assert UserOption.objects.get_value(user=self.user, key="timezone") == "UTC"
-        assert UserOption.objects.get_value(user=self.user, key="stacktrace_order") == "2"
+        assert (
+            UserOption.objects.get_value(user=self.user, key="stacktrace_order")
+            == StacktraceOrder.MOST_RECENT_FIRST
+        )
         assert UserOption.objects.get_value(user=self.user, key="language") == "fr"
         assert UserOption.objects.get_value(user=self.user, key="clock_24_hours")
         assert UserOption.objects.get_value(