Skip to content

Commit 69fd725

Browse files
wmakwmak
committed
fix: Missing spots to update
1 parent f7af13d commit 69fd725

21 files changed

+120
-122
lines changed

‎static/app/views/dashboards/widgetBuilder/utils.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ describe('WidgetBuilder utils', function () {
3131
});
3232

3333
it('does not split aggregates with inner commas', function () {
34-
const testFieldsString = 'p75(),count_if(transaction.duration,equal,200),p95()';
34+
const testFieldsString = 'p75(),count_if(transaction.duration,equals,200),p95()';
3535
const actual = getFields(testFieldsString);
3636
expect(actual).toEqual([
3737
'p75()',
38-
'count_if(transaction.duration,equal,200)',
38+
'count_if(transaction.duration,equals,200)',
3939
'p95()',
4040
]);
4141
});

‎static/app/views/insights/mobile/appStarts/components/tables/screensTable.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ describe('AppStartScreens', () => {
7676
{
7777
id: '1',
7878
transaction: 'Screen 1',
79-
'avg_if(measurements.app_start_cold,release,com.example.vu.android@2.10.5)': 100,
80-
'avg_if(measurements.app_start_cold,release,com.example.vu.android@2.10.3+42)': 200,
79+
'avg_if(measurements.app_start_cold,release,equals,com.example.vu.android@2.10.5)': 100,
80+
'avg_if(measurements.app_start_cold,release,equals,com.example.vu.android@2.10.3+42)': 200,
8181
'avg_compare(measurements.app_start_cold,release,com.example.vu.android@2.10.5,com.example.vu.android@2.10.3+42)': 50,
8282
app_start_breakdown: 'breakdown',
8383
'count_starts(measurements.app_start_cold)': 10,

‎static/app/views/insights/mobile/appStarts/components/tables/screensTable.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,19 @@ export function AppStartScreens({data, eventView, isLoading, pageLinks}: Props)
3939

4040
const columnNameMap = {
4141
transaction: t('Screen'),
42-
[`avg_if(measurements.app_start_cold,release,${primaryRelease})`]: t(
42+
[`avg_if(measurements.app_start_cold,release,equals,${primaryRelease})`]: t(
4343
'Avg Cold Start (%s)',
4444
PRIMARY_RELEASE_ALIAS
4545
),
46-
[`avg_if(measurements.app_start_cold,release,${secondaryRelease})`]: t(
46+
[`avg_if(measurements.app_start_cold,release,equals,${secondaryRelease})`]: t(
4747
'Avg Cold Start (%s)',
4848
SECONDARY_RELEASE_ALIAS
4949
),
50-
[`avg_if(measurements.app_start_warm,release,${primaryRelease})`]: t(
50+
[`avg_if(measurements.app_start_warm,release,equals,${primaryRelease})`]: t(
5151
'Avg Warm Start (%s)',
5252
PRIMARY_RELEASE_ALIAS
5353
),
54-
[`avg_if(measurements.app_start_warm,release,${secondaryRelease})`]: t(
54+
[`avg_if(measurements.app_start_warm,release,equals,${secondaryRelease})`]: t(
5555
'Avg Warm Start (%s)',
5656
SECONDARY_RELEASE_ALIAS
5757
),
@@ -135,8 +135,8 @@ export function AppStartScreens({data, eventView, isLoading, pageLinks}: Props)
135135
pageLinks={pageLinks}
136136
columnOrder={[
137137
'transaction',
138-
`avg_if(measurements.app_start_${startType},release,${primaryRelease})`,
139-
`avg_if(measurements.app_start_${startType},release,${secondaryRelease})`,
138+
`avg_if(measurements.app_start_${startType},release,equals,${primaryRelease})`,
139+
`avg_if(measurements.app_start_${startType},release,equals,${secondaryRelease})`,
140140
`avg_compare(measurements.app_start_${startType},release,${primaryRelease},${secondaryRelease})`,
141141
'app_start_breakdown',
142142
`count_starts(measurements.app_start_${startType})`,

‎static/app/views/insights/mobile/appStarts/components/tables/spanOperationTable.spec.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ describe('SpanOpSelector', function () {
5454
'span.op': 'string',
5555
'span.description': 'string',
5656
'span.group': 'string',
57-
'avg_if(span.self_time,release,release1)': 'duration',
57+
'avg_if(span.self_time,release,equals,release1)': 'duration',
5858
'avg_compare(span.self_time,release,release1,release2)': 'percent_change',
5959
'count()': 'integer',
60-
'avg_if(span.self_time,release,release2)': 'duration',
60+
'avg_if(span.self_time,release,equals,release2)': 'duration',
6161
'sum(span.self_time)': 'duration',
6262
},
6363
},
@@ -67,10 +67,10 @@ describe('SpanOpSelector', function () {
6767
'span.op': 'app.start.warm',
6868
'span.description': 'Application Init',
6969
'span.group': '7f4be68f08c0455f',
70-
'avg_if(span.self_time,release,release1)': 22.549867,
70+
'avg_if(span.self_time,release,equals,release1)': 22.549867,
7171
'avg_compare(span.self_time,release,release1,release2)': 0.5,
7272
'count()': 14,
73-
'avg_if(span.self_time,release,release2)': 12504.931908384617,
73+
'avg_if(span.self_time,release,equals,release2)': 12504.931908384617,
7474
'sum(span.self_time)': 162586.66467600001,
7575
},
7676
],
@@ -115,10 +115,10 @@ describe('SpanOpSelector', function () {
115115
'span.op': 'string',
116116
'span.description': 'string',
117117
'span.group': 'string',
118-
'avg_if(span.self_time,release,release1)': 'duration',
118+
'avg_if(span.self_time,release,equals,release1)': 'duration',
119119
'avg_compare(span.self_time,release,release1,release2)': 'percent_change',
120120
'count()': 'integer',
121-
'avg_if(span.self_time,release,release2)': 'duration',
121+
'avg_if(span.self_time,release,equals,release2)': 'duration',
122122
'sum(span.self_time)': 'duration',
123123
},
124124
},
@@ -132,8 +132,8 @@ describe('SpanOpSelector', function () {
132132
'sum(span.self_time)': 162586.66467600001,
133133

134134
// simulate a scenario where a span was added in release 2
135-
'avg_if(span.self_time,release,release1)': 0,
136-
'avg_if(span.self_time,release,release2)': 12504.931908384617,
135+
'avg_if(span.self_time,release,equals,release1)': 0,
136+
'avg_if(span.self_time,release,equals,release2)': 12504.931908384617,
137137
'avg_compare(span.self_time,release,release1,release2)': null,
138138
},
139139
],

‎static/app/views/insights/mobile/appStarts/components/tables/spanOperationTable.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ export function SpanOperationTable({
117117
SPAN_OP,
118118
SPAN_GROUP,
119119
SPAN_DESCRIPTION,
120-
`avg_if(${SPAN_SELF_TIME},release,${primaryRelease})`,
121-
`avg_if(${SPAN_SELF_TIME},release,${secondaryRelease})`,
120+
`avg_if(${SPAN_SELF_TIME},release,equals,${primaryRelease})`,
121+
`avg_if(${SPAN_SELF_TIME},release,equals,${secondaryRelease})`,
122122
`avg_compare(${SPAN_SELF_TIME},release,${primaryRelease},${secondaryRelease})`,
123123
`sum(${SPAN_SELF_TIME})`,
124124
],
@@ -131,11 +131,11 @@ export function SpanOperationTable({
131131
const columnNameMap = {
132132
[SPAN_OP]: t('Operation'),
133133
[SPAN_DESCRIPTION]: t('Span Description'),
134-
[`avg_if(${SPAN_SELF_TIME},release,${primaryRelease})`]: t(
134+
[`avg_if(${SPAN_SELF_TIME},release,equals,${primaryRelease})`]: t(
135135
'Avg Duration (%s)',
136136
PRIMARY_RELEASE_ALIAS
137137
),
138-
[`avg_if(${SPAN_SELF_TIME},release,${secondaryRelease})`]: t(
138+
[`avg_if(${SPAN_SELF_TIME},release,equals,${secondaryRelease})`]: t(
139139
'Avg Duration (%s)',
140140
SECONDARY_RELEASE_ALIAS
141141
),
@@ -249,8 +249,8 @@ export function SpanOperationTable({
249249
columnOrder={[
250250
String(SPAN_OP),
251251
String(SPAN_DESCRIPTION),
252-
`avg_if(${SPAN_SELF_TIME},release,${primaryRelease})`,
253-
`avg_if(${SPAN_SELF_TIME},release,${secondaryRelease})`,
252+
`avg_if(${SPAN_SELF_TIME},release,equals,${primaryRelease})`,
253+
`avg_if(${SPAN_SELF_TIME},release,equals,${secondaryRelease})`,
254254
`avg_compare(${SPAN_SELF_TIME},release,${primaryRelease},${secondaryRelease})`,
255255
].map(col => {
256256
return {key: col, name: columnNameMap[col] ?? col, width: COL_WIDTH_UNDEFINED};

‎static/app/views/insights/mobile/screenload/components/tables/screenLoadSpansTable.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ describe('ScreenLoadSpansTable', function () {
8181
'span.op',
8282
'span.group',
8383
'span.description',
84-
'avg_if(span.self_time,release,io.sentry.samples.android@7.0.0+2)',
85-
'avg_if(span.self_time,release,io.sentry.samples.android@6.27.0+2)',
84+
'avg_if(span.self_time,release,equals,io.sentry.samples.android@7.0.0+2)',
85+
'avg_if(span.self_time,release,equals,io.sentry.samples.android@6.27.0+2)',
8686
'ttid_contribution_rate()',
8787
'ttfd_contribution_rate()',
8888
'count()',

‎static/app/views/insights/mobile/screenload/components/tables/screenLoadSpansTable.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ export function ScreenLoadSpansTable({
108108
SPAN_OP,
109109
SPAN_GROUP,
110110
SPAN_DESCRIPTION,
111-
`avg_if(${SPAN_SELF_TIME},release,${primaryRelease})`,
112-
`avg_if(${SPAN_SELF_TIME},release,${secondaryRelease})`,
111+
`avg_if(${SPAN_SELF_TIME},release,equals,${primaryRelease})`,
112+
`avg_if(${SPAN_SELF_TIME},release,equals,${secondaryRelease})`,
113113
'ttid_contribution_rate()',
114114
'ttfd_contribution_rate()',
115115
'count()',
@@ -125,11 +125,11 @@ export function ScreenLoadSpansTable({
125125
'count()': t('Total Count'),
126126
affects: hasTTFD ? t('Affects') : t('Affects TTID'),
127127
[`sum(${SPAN_SELF_TIME})`]: t('Total Time Spent'),
128-
[`avg_if(${SPAN_SELF_TIME},release,${primaryRelease})`]: t(
128+
[`avg_if(${SPAN_SELF_TIME},release,equals,${primaryRelease})`]: t(
129129
'Avg Duration (%s)',
130130
PRIMARY_RELEASE_ALIAS
131131
),
132-
[`avg_if(${SPAN_SELF_TIME},release,${secondaryRelease})`]: t(
132+
[`avg_if(${SPAN_SELF_TIME},release,equals,${secondaryRelease})`]: t(
133133
'Avg Duration (%s)',
134134
SECONDARY_RELEASE_ALIAS
135135
),
@@ -351,8 +351,8 @@ export function ScreenLoadSpansTable({
351351
columnOrder={[
352352
String(SPAN_OP),
353353
String(SPAN_DESCRIPTION),
354-
`avg_if(${SPAN_SELF_TIME},release,${primaryRelease})`,
355-
`avg_if(${SPAN_SELF_TIME},release,${secondaryRelease})`,
354+
`avg_if(${SPAN_SELF_TIME},release,equals,${primaryRelease})`,
355+
`avg_if(${SPAN_SELF_TIME},release,equals,${secondaryRelease})`,
356356
...(organization.features.includes('insights-initial-modules')
357357
? ['affects']
358358
: []),

‎static/app/views/insights/mobile/screenload/views/screenLoadSpansPage.tsx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -78,42 +78,42 @@ export function ScreenLoadSpansContent() {
7878
`transaction:${transactionName}`,
7979
]}
8080
fields={[
81-
`avg_if(measurements.time_to_initial_display,release,${primaryRelease})`,
82-
`avg_if(measurements.time_to_initial_display,release,${secondaryRelease})`,
83-
`avg_if(measurements.time_to_full_display,release,${primaryRelease})`,
84-
`avg_if(measurements.time_to_full_display,release,${secondaryRelease})`,
85-
`count_if(measurements.time_to_initial_display,release,${primaryRelease})`,
86-
`count_if(measurements.time_to_initial_display,release,${secondaryRelease})`,
81+
`avg_if(measurements.time_to_initial_display,release,equals,${primaryRelease})`,
82+
`avg_if(measurements.time_to_initial_display,release,equals,${secondaryRelease})`,
83+
`avg_if(measurements.time_to_full_display,release,equals,${primaryRelease})`,
84+
`avg_if(measurements.time_to_full_display,release,equals,${secondaryRelease})`,
85+
`count_if(measurements.time_to_initial_display,release,equals,${primaryRelease})`,
86+
`count_if(measurements.time_to_initial_display,release,equals,${secondaryRelease})`,
8787
]}
8888
blocks={[
8989
{
9090
unit: DurationUnit.MILLISECOND,
91-
dataKey: `avg_if(measurements.time_to_initial_display,release,${primaryRelease})`,
91+
dataKey: `avg_if(measurements.time_to_initial_display,release,equals,${primaryRelease})`,
9292
title: t('Avg TTID (%s)', PRIMARY_RELEASE_ALIAS),
9393
},
9494
{
9595
unit: DurationUnit.MILLISECOND,
96-
dataKey: `avg_if(measurements.time_to_initial_display,release,${secondaryRelease})`,
96+
dataKey: `avg_if(measurements.time_to_initial_display,release,equals,${secondaryRelease})`,
9797
title: t('Avg TTID (%s)', SECONDARY_RELEASE_ALIAS),
9898
},
9999
{
100100
unit: DurationUnit.MILLISECOND,
101-
dataKey: `avg_if(measurements.time_to_full_display,release,${primaryRelease})`,
101+
dataKey: `avg_if(measurements.time_to_full_display,release,equals,${primaryRelease})`,
102102
title: t('Avg TTFD (%s)', PRIMARY_RELEASE_ALIAS),
103103
},
104104
{
105105
unit: DurationUnit.MILLISECOND,
106-
dataKey: `avg_if(measurements.time_to_full_display,release,${secondaryRelease})`,
106+
dataKey: `avg_if(measurements.time_to_full_display,release,equals,${secondaryRelease})`,
107107
title: t('Avg TTFD (%s)', SECONDARY_RELEASE_ALIAS),
108108
},
109109
{
110110
unit: 'count',
111-
dataKey: `count_if(measurements.time_to_initial_display,release,${primaryRelease})`,
111+
dataKey: `count_if(measurements.time_to_initial_display,release,equals,${primaryRelease})`,
112112
title: t('Total Count (%s)', PRIMARY_RELEASE_ALIAS),
113113
},
114114
{
115115
unit: 'count',
116-
dataKey: `count_if(measurements.time_to_initial_display,release,${secondaryRelease})`,
116+
dataKey: `count_if(measurements.time_to_initial_display,release,equals,${secondaryRelease})`,
117117
title: t('Total Count (%s)', SECONDARY_RELEASE_ALIAS),
118118
},
119119
]}

‎static/app/views/insights/mobile/ui/components/tables/spanOperationTable.spec.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ describe('SpanOperationTable', () => {
5050
'span.op',
5151
'span.group',
5252
'span.description',
53-
'division_if(mobile.slow_frames,mobile.total_frames,release,foo)',
54-
'division_if(mobile.slow_frames,mobile.total_frames,release,bar)',
55-
'division_if(mobile.frozen_frames,mobile.total_frames,release,foo)',
56-
'division_if(mobile.frozen_frames,mobile.total_frames,release,bar)',
57-
'avg_if(mobile.frames_delay,release,foo)',
58-
'avg_if(mobile.frames_delay,release,bar)',
53+
'division_if(mobile.slow_frames,mobile.total_frames,equals,release,foo)',
54+
'division_if(mobile.slow_frames,mobile.total_frames,equals,release,bar)',
55+
'division_if(mobile.frozen_frames,mobile.total_frames,equals,release,foo)',
56+
'division_if(mobile.frozen_frames,mobile.total_frames,equals,release,bar)',
57+
'avg_if(mobile.frames_delay,release,equals,foo)',
58+
'avg_if(mobile.frames_delay,release,equals,bar)',
5959
'avg_compare(mobile.frames_delay,release,foo,bar)',
6060
],
6161
}),

0 commit comments

Comments
 (0)