Skip to content

Commit 84ddde9

Browse files
committed
add TODOs
1 parent dcad786 commit 84ddde9

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/sentry/interfaces/stacktrace.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ def get_context(lineno, context_line, pre_context=None, post_context=None):
9393

9494

9595
def is_newest_frame_first(event):
96+
# TODO: Investigate if we should keep this special-casing for python, since we don't special
97+
# case it anywhere else we check stacktrace order.
98+
# (See https://github.com/getsentry/sentry/pull/96719 for more context.)
9699
newest_first = event.platform not in ("python", None)
97100

98101
if env.request and env.request.user.is_authenticated:

src/sentry/users/api/serializers/user.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,9 @@ def serialize(
194194
}
195195

196196
stacktrace_order = int(
197-
options.get("stacktrace_order", StacktraceOrder.DEFAULT) or StacktraceOrder.DEFAULT
197+
options.get("stacktrace_order", StacktraceOrder.DEFAULT)
198+
# TODO: This second `or` won't be necessary once we remove empty strings from the DB
199+
or StacktraceOrder.DEFAULT
198200
)
199201

200202
d["options"] = {

0 commit comments

Comments
 (0)