Skip to content

Commit 903dda1

Browse files
evanpurkhiserandrewshie-sentry
authored andcommitted
ref(crons): Remove unneeded self.tasks in detector index tests (#103110)
1 parent 646091a commit 903dda1

File tree

1 file changed

+27
-32
lines changed

1 file changed

+27
-32
lines changed

tests/sentry/monitors/endpoints/test_organization_detector_index.py

Lines changed: 27 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,11 @@ def _get_detector_post_data(self, **overrides):
116116

117117
def test_create_monitor_incident_detector_validates_correctly(self):
118118
data = self._get_detector_post_data()
119-
with self.tasks():
120-
response = self.get_success_response(
121-
self.organization.slug,
122-
**data,
123-
status_code=201,
124-
)
119+
response = self.get_success_response(
120+
self.organization.slug,
121+
**data,
122+
status_code=201,
123+
)
125124

126125
assert response.data["name"] == "Test Monitor Detector"
127126
assert response.data["type"] == MonitorIncidentType.slug
@@ -195,12 +194,11 @@ def test_create_monitor_with_optional_fields(self):
195194
}
196195
],
197196
)
198-
with self.tasks():
199-
self.get_success_response(
200-
self.organization.slug,
201-
**data,
202-
status_code=201,
203-
)
197+
self.get_success_response(
198+
self.organization.slug,
199+
**data,
200+
status_code=201,
201+
)
204202

205203
monitor = Monitor.objects.get(
206204
organization_id=self.organization.id, slug="full-config-monitor"
@@ -228,13 +226,12 @@ def test_update_monitor_incident_detector(self):
228226
"name": "Updated Detector",
229227
"owner": new_user.get_actor_identifier(),
230228
}
231-
with self.tasks():
232-
response = self.get_success_response(
233-
self.organization.slug,
234-
self.detector.id,
235-
**data,
236-
status_code=200,
237-
)
229+
response = self.get_success_response(
230+
self.organization.slug,
231+
self.detector.id,
232+
**data,
233+
status_code=200,
234+
)
238235

239236
assert response.data["name"] == "Updated Detector"
240237
assert response.data["owner"] == {
@@ -269,13 +266,12 @@ def test_update_monitor_config_through_detector(self):
269266
}
270267
],
271268
}
272-
with self.tasks():
273-
self.get_success_response(
274-
self.organization.slug,
275-
self.detector.id,
276-
**data,
277-
status_code=200,
278-
)
269+
self.get_success_response(
270+
self.organization.slug,
271+
self.detector.id,
272+
**data,
273+
status_code=200,
274+
)
279275

280276
self.detector.refresh_from_db()
281277
assert self.detector.name == "Updated Detector With Monitor Config"
@@ -295,12 +291,11 @@ class OrganizationDetectorDeleteTest(BaseDetectorTestCase):
295291
def test_delete_monitor_incident_detector(self):
296292
detector_id = self.detector.id
297293
monitor_id = self.monitor.id
298-
with self.tasks():
299-
self.get_success_response(
300-
self.organization.slug,
301-
detector_id,
302-
status_code=204,
303-
)
294+
self.get_success_response(
295+
self.organization.slug,
296+
detector_id,
297+
status_code=204,
298+
)
304299
self.detector.refresh_from_db()
305300
assert self.detector.status == ObjectStatus.PENDING_DELETION
306301
assert Monitor.objects.filter(id=monitor_id).exists()

0 commit comments

Comments
 (0)