Skip to content

Commit ab831b5

Browse files
kconsandrewshie-sentry
authored andcommitted
fix(aci): Fix Workflow serializer lastTriggered (#96688)
We need to use `values()` to ensure we're not implicitly grouping by `workflowfirehistory.id` rather than `workflowfirehistory.workflow_id`. Updates tests to ensure undoing this will fail.
1 parent b9bbb7a commit ab831b5

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

src/sentry/workflow_engine/endpoints/serializers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,7 @@ def get_attrs(
403403
WorkflowFireHistory.objects.filter(
404404
workflow__in=item_list,
405405
)
406+
.values("workflow_id")
406407
.annotate(last_triggered=Max("date_added"))
407408
.values_list("workflow_id", "last_triggered")
408409
)

tests/sentry/workflow_engine/endpoints/test_serializers.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,8 +454,14 @@ def test_serialize_full(self) -> None:
454454
workflow=workflow,
455455
group=self.group,
456456
event_id=self.event.event_id,
457-
date_added=workflow.date_added + timedelta(seconds=1),
458457
)
458+
WorkflowFireHistory.objects.create(
459+
workflow=workflow,
460+
group=self.group,
461+
event_id=self.event.event_id,
462+
)
463+
history.date_added = workflow.date_added + timedelta(seconds=1)
464+
history.save()
459465

460466
result = serialize(workflow)
461467

0 commit comments

Comments
 (0)