Skip to content

Commit b9278a2

Browse files
authored
ref(logs): Remove blockRowExpanding from logs page params (#96800)
There's no reason for `blockRowExpanding` to be in the page params when it can be directly passed the `LogRowContent`.
1 parent cfec8da commit b9278a2

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

static/app/components/events/ourlogs/ourlogsSection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ export function OurlogsSection({
4040
<LogsPageParamsProvider
4141
analyticsPageSource={LogsAnalyticsPageSource.ISSUE_DETAILS}
4242
isTableFrozen
43-
blockRowExpanding
4443
limitToTraceId={event.contexts?.trace?.trace_id}
4544
>
4645
<LogsPageDataProvider>
@@ -127,6 +126,7 @@ function OurlogsSectionContent({
127126
highlightTerms={[]}
128127
sharedHoverTimeoutRef={sharedHoverTimeoutRef}
129128
key={index}
129+
blockRowExpanding
130130
/>
131131
))}
132132
</TableBody>

static/app/views/explore/contexts/logs/logsPageParams.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ interface LogsPageParams {
5151
/** In the 'aggregates' table, if you GROUP BY, there can be many rows. This is the 'sort by' for that table. */
5252
readonly aggregateSortBys: Sort[];
5353
readonly analyticsPageSource: LogsAnalyticsPageSource;
54-
readonly blockRowExpanding: boolean | undefined;
5554
readonly cursor: string;
5655
readonly fields: string[];
5756
readonly isTableFrozen: boolean | undefined;
@@ -120,7 +119,6 @@ interface LogsPageParamsProviderProps {
120119
autoRefresh?: AutoRefreshState;
121120
refreshInterval?: number;
122121
};
123-
blockRowExpanding?: boolean;
124122
isTableFrozen?: boolean;
125123
limitToProjectIds?: number[];
126124
limitToSpanId?: string;
@@ -132,7 +130,6 @@ export function LogsPageParamsProvider({
132130
limitToTraceId,
133131
limitToSpanId,
134132
limitToProjectIds,
135-
blockRowExpanding,
136133
isTableFrozen,
137134
analyticsPageSource,
138135
_testContext,
@@ -200,7 +197,6 @@ export function LogsPageParamsProvider({
200197
cursor,
201198
setCursorForFrozenPages,
202199
isTableFrozen,
203-
blockRowExpanding,
204200
baseSearch,
205201
projectIds,
206202
analyticsPageSource,
@@ -391,11 +387,6 @@ export function useLogsIsTableFrozen() {
391387
return !!isTableFrozen;
392388
}
393389

394-
export function useLogsBlockRowExpanding() {
395-
const {blockRowExpanding} = useLogsPageParams();
396-
return !!blockRowExpanding;
397-
}
398-
399390
export function usePersistedLogsPageParams() {
400391
useLayoutEffect(() => {
401392
const pastParams = localStorage.getItem(

static/app/views/explore/logs/tables/logsTableRow.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import {
2929
} from 'sentry/views/explore/contexts/logs/logsAutoRefreshContext';
3030
import {
3131
useLogsAnalyticsPageSource,
32-
useLogsBlockRowExpanding,
3332
useLogsFields,
3433
useLogsIsTableFrozen,
3534
useLogsSearch,
@@ -80,6 +79,7 @@ type LogsRowProps = {
8079
highlightTerms: string[];
8180
meta: EventsMetaType | undefined;
8281
sharedHoverTimeoutRef: React.MutableRefObject<NodeJS.Timeout | null>;
82+
blockRowExpanding?: boolean;
8383
canDeferRenderElements?: boolean;
8484
isExpanded?: boolean;
8585
onCollapse?: (logItemId: string) => void;
@@ -117,6 +117,7 @@ export const LogRowContent = memo(function LogRowContent({
117117
onExpand,
118118
onCollapse,
119119
onExpandHeight,
120+
blockRowExpanding,
120121
canDeferRenderElements,
121122
}: LogsRowProps) {
122123
const location = useLocation();
@@ -125,7 +126,6 @@ export const LogRowContent = memo(function LogRowContent({
125126
const search = useLogsSearch();
126127
const setLogsSearch = useSetLogsSearch();
127128
const isTableFrozen = useLogsIsTableFrozen();
128-
const blockRowExpanding = useLogsBlockRowExpanding();
129129
const autorefreshEnabled = useLogsAutoRefreshEnabled();
130130
const setAutorefresh = useSetLogsAutoRefresh();
131131
const measureRef = useRef<HTMLTableRowElement>(null);

0 commit comments

Comments
 (0)