feat(release health): Update snuba metrics to know about session unhandled state

Author: ryan953

src/sentry/snuba/metrics/fields/snql.py

@@ -246,6 +246,20 @@ def all_users(org_id: int, metric_ids: Sequence[int], alias: str | None = None)
     return uniq_aggregation_on_metric(metric_ids, alias)
 
 
+def unhandled_sessions(
+    org_id: int, metric_ids: Sequence[int], alias: str | None = None
+) -> Function:
+    return _counter_sum_aggregation_on_session_status_factory(
+        org_id, session_status="unhandled", metric_ids=metric_ids, alias=alias
+    )
+
+
+def unhandled_users(org_id: int, metric_ids: Sequence[int], alias: str | None = None) -> Function:
+    return _set_uniq_aggregation_on_session_status_factory(
+        org_id, session_status="unhandled", metric_ids=metric_ids, alias=alias
+    )
+
+
 def crashed_sessions(org_id: int, metric_ids: Sequence[int], alias: str | None = None) -> Function:
     return _counter_sum_aggregation_on_session_status_factory(
         org_id, session_status="crashed", metric_ids=metric_ids, alias=alias

src/sentry/snuba/metrics/naming_layer/mri.py

@@ -72,20 +72,32 @@ class SessionMRI(Enum):
     ERRORED_PREAGGREGATED = "e:sessions/error.preaggr@none"
     ERRORED_SET = "e:sessions/error.unique@none"
     ERRORED_ALL = "e:sessions/all_errored@none"
+    HANDLED = "e:sessions/handled.unique@none"  # all sessions excluding handled and crashed
+    UNHANDLED = "e:sessions/unhandled@none"  # unhandled, does not include crashed
     CRASHED_AND_ABNORMAL = "e:sessions/crashed_abnormal@none"
     CRASHED = "e:sessions/crashed@none"
     CRASH_FREE = "e:sessions/crash_free@none"
     ABNORMAL = "e:sessions/abnormal@none"
+    HANDLED_RATE = "e:sessions/handled_rate@ratio"  # all sessions excluding handled and crashed
+    UNHANDLED_RATE = "e:sessions/unhandled_rate@ratio"  # unhandled, does not include crashed
     CRASH_RATE = "e:sessions/crash_rate@ratio"
-    CRASH_FREE_RATE = "e:sessions/crash_free_rate@ratio"
+    CRASH_FREE_RATE = "e:sessions/crash_free_rate@ratio"  # includes handled and unhandled
     ALL_USER = "e:sessions/user.all@none"
     HEALTHY_USER = "e:sessions/user.healthy@none"
     ERRORED_USER = "e:sessions/user.errored@none"
     ERRORED_USER_ALL = "e:sessions/user.all_errored@none"
+    HANDLED_USER = "e:sessions/user.handled@none"  # all sessions excluding handled and crashed
+    UNHANDLED_USER = "e:sessions/user.unhandled@none"  # unhandled, does not include crashed
     CRASHED_AND_ABNORMAL_USER = "e:sessions/user.crashed_abnormal@none"
     CRASHED_USER = "e:sessions/user.crashed@none"
     CRASH_FREE_USER = "e:sessions/user.crash_free@none"
     ABNORMAL_USER = "e:sessions/user.abnormal@none"
+    HANDLED_USER_RATE = (
+        "e:sessions/user.handled_rate@ratio"  # all sessions excluding handled and crashed
+    )
+    UNHANDLED_USER_RATE = (
+        "e:sessions/user.unhandled_rate@ratio"  # unhandled, does not include crashed
+    )
     CRASH_USER_RATE = "e:sessions/user.crash_rate@ratio"
     CRASH_FREE_USER_RATE = "e:sessions/user.crash_free_rate@ratio"
     ANR_USER = "e:sessions/user.anr@none"

src/sentry/snuba/metrics/naming_layer/public.py

@@ -36,6 +36,7 @@ class SessionMetricKey(Enum):
     DURATION = "session.duration"
     ALL = "session.all"
     ABNORMAL = "session.abnormal"
+    UNHANDLED = "session.unhandled"
     CRASHED = "session.crashed"
     CRASH_FREE = "session.crash_free"
     ERRORED = "session.errored"
@@ -46,6 +47,7 @@ class SessionMetricKey(Enum):
     ALL_USER = "session.all_user"
     ABNORMAL_USER = "session.abnormal_user"
     CRASHED_USER = "session.crashed_user"
+    UNHANDLED_USER = "session.unhandled_user"
     CRASH_FREE_USER = "session.crash_free_user"
     ERRORED_USER = "session.errored_user"
     HEALTHY_USER = "session.healthy_user"

tests/sentry/snuba/metrics/test_snql.py

@@ -33,6 +33,8 @@
     session_duration_filters,
     subtraction,
     tolerated_count_transaction,
+    unhandled_sessions,
+    unhandled_users,
     uniq_aggregation_on_metric,
     uniq_if_column_snql,
 )
@@ -70,6 +72,7 @@ def setUp(self) -> None:
                         "errored",
                         "exited",
                         "init",
+                        "unhandled",
                         "session.status",
                     }
                 }
@@ -98,6 +101,7 @@ def test_counter_sum_aggregation_on_session_status(self) -> None:
             ("crashed", crashed_sessions),
             ("errored_preaggr", errored_preaggr_sessions),
             ("abnormal", abnormal_sessions),
+            ("unhandled", unhandled_sessions),
         ]:
             assert func(self.org_id, self.metric_ids, alias=status) == Function(
                 "sumIf",
@@ -129,6 +133,7 @@ def test_set_uniq_aggregation_on_session_status(self) -> None:
             ("crashed", crashed_users),
             ("abnormal", abnormal_users),
             ("errored", errored_all_users),
+            ("unhandled", unhandled_users),
         ]:
             assert func(self.org_id, self.metric_ids, alias=status) == Function(
                 "uniqIf",