fix(aci): Limit lastTriggered to single-written history (#96792)

Dual-written WorkflowActionHistory records are non-canonical, and
shouldn't be included in results.

Author: kcons

src/sentry/workflow_engine/endpoints/organization_workflow_index.py

@@ -160,7 +160,13 @@ def get(self, request, organization):
                 # the annotated value isn't returned in the results.
                 long_ago = ensure_aware(datetime(1970, 1, 1))
                 queryset = queryset.annotate(
-                    last_triggered=Max(Coalesce("workflowfirehistory__date_added", long_ago)),
+                    last_triggered=Coalesce(
+                        Max(
+                            "workflowfirehistory__date_added",
+                            filter=Q(workflowfirehistory__is_single_written=True),
+                        ),
+                        long_ago,
+                    ),
                 )
 
         queryset = queryset.order_by(*sort_by.db_order_by)

src/sentry/workflow_engine/endpoints/serializers.py

@@ -402,6 +402,7 @@ def get_attrs(
         last_triggered_map: dict[int, datetime] = dict(
             WorkflowFireHistory.objects.filter(
                 workflow__in=item_list,
+                is_single_written=True,
             )
             .values("workflow_id")
             .annotate(last_triggered=Max("date_added"))

tests/sentry/workflow_engine/endpoints/test_organization_workflow_index.py

@@ -6,9 +6,13 @@
 from sentry.notifications.models.notificationaction import ActionTarget
 from sentry.testutils.cases import APITestCase
 from sentry.testutils.silo import region_silo_test
-from sentry.workflow_engine.models import Action, Workflow, WorkflowDataConditionGroup
-from sentry.workflow_engine.models.detector_workflow import DetectorWorkflow
-from sentry.workflow_engine.models.workflow_fire_history import WorkflowFireHistory
+from sentry.workflow_engine.models import (
+    Action,
+    DetectorWorkflow,
+    Workflow,
+    WorkflowDataConditionGroup,
+    WorkflowFireHistory,
+)
 
 
 class OrganizationWorkflowAPITestCase(APITestCase):
@@ -40,6 +44,7 @@ def setUp(self) -> None:
                 workflow=workflow,
                 group=self.group,
                 event_id=self.event.event_id,
+                is_single_written=True,
             )
 
     def test_simple(self) -> None:
@@ -190,6 +195,13 @@ def test_sort_by_actions(self) -> None:
         ][0]
 
     def test_sort_by_last_triggered(self) -> None:
+        # Fresh fire for self.workflow that would impact sorting if not ignored.
+        WorkflowFireHistory.objects.create(
+            workflow=self.workflow,
+            group=self.group,
+            event_id=self.event.event_id,
+            is_single_written=False,
+        )
         response = self.get_success_response(
             self.organization.slug, qs_params={"sortBy": "lastTriggered"}
         )
@@ -325,6 +337,53 @@ def test_query_filter_by_action(self) -> None:
         assert len(response3.data) == 2
         assert {self.workflow.name, self.workflow_two.name} == {w["name"] for w in response3.data}
 
+    def test_sort_by_last_triggered_with_non_single_written_only(self) -> None:
+        workflow_never_fired = self.create_workflow(
+            organization_id=self.organization.id, name="Never Fired"
+        )
+
+        workflow_non_single_written_only = self.create_workflow(
+            organization_id=self.organization.id, name="Non Single Written Only"
+        )
+        WorkflowFireHistory.objects.create(
+            workflow=workflow_non_single_written_only,
+            group=self.group,
+            event_id=self.event.event_id,
+            is_single_written=False,
+        )
+
+        # Test ascending order (lastTriggered)
+        response = self.get_success_response(
+            self.organization.slug, qs_params={"sortBy": "lastTriggered"}
+        )
+
+        # Workflows without single-written history should come first, then those with it
+        expected_ascending_order = [
+            self.workflow_three.name,
+            workflow_never_fired.name,
+            workflow_non_single_written_only.name,
+            self.workflow.name,
+            self.workflow_two.name,
+        ]
+
+        assert [w["name"] for w in response.data] == expected_ascending_order
+
+        # Test descending order (-lastTriggered)
+        response_desc = self.get_success_response(
+            self.organization.slug, qs_params={"sortBy": "-lastTriggered"}
+        )
+
+        # In descending order, workflows with single-written history should come first
+        expected_descending_order = [
+            self.workflow_two.name,
+            self.workflow.name,
+            workflow_non_single_written_only.name,
+            workflow_never_fired.name,
+            self.workflow_three.name,
+        ]
+
+        assert [w["name"] for w in response_desc.data] == expected_descending_order
+
     def test_compound_query(self) -> None:
         self.create_detector_workflow(
             workflow=self.workflow, detector=self.create_detector(project=self.project)

tests/sentry/workflow_engine/endpoints/test_serializers.py

@@ -450,18 +450,31 @@ def test_serialize_full(self) -> None:
             detector=detector,
             workflow=workflow,
         )
+
         history = WorkflowFireHistory.objects.create(
             workflow=workflow,
             group=self.group,
             event_id=self.event.event_id,
+            is_single_written=True,
         )
+        # Too old, shouldn't be used.
         WorkflowFireHistory.objects.create(
             workflow=workflow,
             group=self.group,
             event_id=self.event.event_id,
+            is_single_written=True,
         )
         history.date_added = workflow.date_added + timedelta(seconds=1)
         history.save()
+        # Dual written, shouldn't be used.
+        dual_written_history = WorkflowFireHistory.objects.create(
+            workflow=workflow,
+            group=self.group,
+            event_id=self.event.event_id,
+            is_single_written=False,
+        )
+        dual_written_history.date_added = workflow.date_added + timedelta(seconds=2)
+        dual_written_history.save()
 
         result = serialize(workflow)