Skip to content

fix(groupingInfo): Filter out null variants before sorting #103180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(groupingInfo): Filter out null variants before sorting #103180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions static/app/components/events/groupingInfo/groupingInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,20 +40,22 @@ export default function GroupingInfo({
});

const variants = groupInfo?.variants
? Object.values(groupInfo.variants).sort((a, b) => {
// Sort contributing variants before non-contributing ones
if (a.contributes && !b.contributes) {
return -1;
}
if (b.contributes && !a.contributes) {
return 1;
}
? Object.values(groupInfo.variants)
.filter((variant): variant is NonNullable<typeof variant> => variant !== null)
.sort((a, b) => {
// Sort contributing variants before non-contributing ones
if (a.contributes && !b.contributes) {
return -1;
}
if (b.contributes && !a.contributes) {
return 1;
}

// Sort by description alphabetically
const descA = a.description?.toLowerCase() ?? '';
const descB = b.description?.toLowerCase() ?? '';
return descA.localeCompare(descB);
})
// Sort by description alphabetically
const descA = a.description?.toLowerCase() ?? '';
const descB = b.description?.toLowerCase() ?? '';
return descA.localeCompare(descB);
})
: [];

const feedbackComponent = (
Expand Down
Loading