feat(preprod): skip comparisons for different analysis versions #103195
+386
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
trevor-e
commented
Nov 11, 2025
| diff_items: list[DiffItem] | ||
| size_metric_diff_item: SizeMetricDiffItem | ||
| skipped_diff_item_comparison: bool | ||
| head_analysis_version: str | None |
Member
Author
There was a problem hiding this comment.
Wasn't sure if the analysis versions should go in SizeMetricDiffItem or not.
trevor-e
commented
Nov 11, 2025
| class ComparisonResults(BaseModel): | ||
| diff_items: list[DiffItem] | ||
| size_metric_diff_item: SizeMetricDiffItem | ||
| skipped_diff_item_comparison: bool |
Member
Author
There was a problem hiding this comment.
Can look for this field in the frontend to show a nice UI around "You should rebase..."
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103195 +/- ##
===========================================
- Coverage 80.67% 80.67% -0.01%
===========================================
Files 9241 9241
Lines 393627 393670 +43
Branches 25053 25053
===========================================
+ Hits 317543 317576 +33
- Misses 75622 75632 +10
Partials 462 462 |
rbro112
reviewed
Nov 11, 2025
| head_size = head_element.size | ||
| if head_size == 0: | ||
| continue | ||
| if not skip_diff_item_comparison: |
Member
There was a problem hiding this comment.
I think we should log the fact we're skipping if so
rbro112
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves EME-629
For now this just handles skipping the treemap diff item comparisons, although we also spoke about perhaps skipping the diff altogether if the major versions differ.