Frontend to show watch app size metrics #103199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103199 +/- ##
========================================
Coverage 80.66% 80.66%
========================================
Files 9241 9241
Lines 393658 393652 -6
Branches 25055 25053 -2
========================================
Hits 317557 317557
+ Misses 75639 75633 -6
Partials 462 462 |
rbro112
force-pushed
the
ryan/frontend_to_show_watch_app_size_metrics
branch
from
67b814a to
b136a1c
Compare
trevor-e
approved these changes
Nov 12, 2025
| <Text>{formatBytesBase10(sizeInfo.install_size_bytes)}</Text> | ||
| <Text> | ||
| {formatBytesBase10( | ||
| getPrimarySizeMetric(sizeInfo)?.install_size_bytes ?? 0 |
Member
There was a problem hiding this comment.
nit: maybe getMainArtifactSizeMetric() so we don't have to translate primary == main
| if (isSizeInfoCompleted(build?.size_info)) { | ||
| return formatBytesBase10(build.size_info.install_size_bytes); | ||
| const primarySizeMetric = getPrimarySizeMetric(build.size_info); | ||
| return formatBytesBase10(primarySizeMetric?.install_size_bytes ?? 0); |
Member
There was a problem hiding this comment.
I wouldn't ?? 0 here, we should try to fall through to return '-';
| } | ||
| } | ||
|
|
||
| export function formattedInstallSize(build: BuildDetailsApiResponse): string { |
Member
There was a problem hiding this comment.
nit: these functions might need renaming
rbro112
force-pushed
the
ryan/frontend_to_show_watch_app_size_metrics
branch
from
8621e31 to
3a9a741
Compare
rbro112
force-pushed
the
ryan/frontend_to_show_watch_app_size_metrics
branch
from
3a9a741 to
fb7f1f7
Compare
Base automatically changed from
ryan/add_all_size_metrics_to_build_details_response
to
master
November 12, 2025 02:20
rbro112
force-pushed
the
ryan/frontend_to_show_watch_app_size_metrics
branch
from
fb7f1f7 to
b8e4c53
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
<img width="365" height="179" alt="Screenshot 2025-11-11 at 3 36 29 PM" src="https://github.com/user-attachments/assets/70be4022-7233-4cd1-a582-4609e1e3679f" /> <img width="324" height="159" alt="Screenshot 2025-11-11 at 3 36 27 PM" src="https://github.com/user-attachments/assets/e8a2b295-ed80-460b-8a3c-e4ad88084da3" /> The above screenshots are correct, I just duplicated the original size metric and changed the artifact type to `WATCH` Resolves EME-580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above screenshots are correct, I just duplicated the original size metric and changed the artifact type to
WATCHResolves EME-580