Merge pull request #234 from ghidoz/fix-parsing-has-many-relationship

Fix parsing has many relationships

Author: safo6m

src/models/json-api.model.spec.ts

@@ -129,6 +129,18 @@ describe('JsonApiModel', () => {
         });
       });
 
+      it('should return an empty array for hasMany relationship when one is included without any elements', () => {
+        const BOOK_NUMBER = 0;
+        const DATA = getAuthorData('books', BOOK_NUMBER);
+        author = new Author(datastore, DATA);
+        author.syncRelationships(DATA, getIncludedBooks(BOOK_NUMBER));
+
+        expect(author).toBeDefined();
+        expect(author.id).toBe(AUTHOR_ID);
+        expect(author.books).toBeDefined();
+        expect(author.books.length).toBe(BOOK_NUMBER);
+      });
+
       it('should parse infinite levels of relationships by reference', () => {
         const BOOK_NUMBER = 4;
         const DATA = getAuthorData('books', BOOK_NUMBER);

src/models/json-api.model.ts

@@ -120,7 +120,7 @@ export class JsonApiModel {
       for (const metadata of hasMany) {
         const relationship: any = data.relationships ? data.relationships[metadata.relationship] : null;
 
-        if (relationship && relationship.data && relationship.data.length > 0) {
+        if (relationship && relationship.data && Array.isArray(relationship.data)) {
           let allModels: JsonApiModel[] = [];
           const modelTypesFetched: any = [];
 
@@ -148,11 +148,9 @@ export class JsonApiModel {
                 throw { message: `parseHasMany - Model type for relationship ${typeName} not found.` };
               }
             }
-
-            if (allModels.length > 0) {
-              this[metadata.propertyName] = allModels;
-            }
           }
+
+          this[metadata.propertyName] = allModels;
         }
       }
     }