From c70c43d49ed2f225476e22a89e9f413c8d0646e3 Mon Sep 17 00:00:00 2001 From: Michael Nebel Date: Thu, 27 Feb 2025 10:10:50 +0100 Subject: [PATCH] C#: Roll back changes for tuples in default to string. --- csharp/ql/src/Useless code/DefaultToStringQuery.qll | 6 ------ 1 file changed, 6 deletions(-) diff --git a/csharp/ql/src/Useless code/DefaultToStringQuery.qll b/csharp/ql/src/Useless code/DefaultToStringQuery.qll index f11b5a9cd324..9185756b0a95 100644 --- a/csharp/ql/src/Useless code/DefaultToStringQuery.qll +++ b/csharp/ql/src/Useless code/DefaultToStringQuery.qll @@ -46,7 +46,6 @@ private predicate alwaysInvokesToString(ParameterRead pr) { * method from `System.Object` or `System.ValueType`. */ predicate alwaysDefaultToString(ValueOrRefType t) { - not t instanceof TupleType and exists(ToStringMethod m | t.hasMethod(m) | m.getDeclaringType() instanceof SystemObjectClass or m.getDeclaringType() instanceof SystemValueTypeClass @@ -56,11 +55,6 @@ predicate alwaysDefaultToString(ValueOrRefType t) { overriding.getABaseType+() = t ) and ((t.isAbstract() or t instanceof Interface) implies not t.isEffectivelyPublic()) - or - exists(ValueOrRefType elem | - elem = t.(TupleType).getElementType(_) and - alwaysDefaultToString(elem) - ) } class DefaultToStringType extends ValueOrRefType {