From ddc429cfebac22b2bbe3d2532b027a0af2ea01bf Mon Sep 17 00:00:00 2001 From: Michael Nebel Date: Tue, 17 Jun 2025 13:16:20 +0200 Subject: [PATCH 1/2] Ruby: Update quality related tags. --- ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql | 5 +++-- ruby/ql/src/queries/variables/DeadStoreOfLocal.ql | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql b/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql index 835fe620984d..b34ee080fcdd 100644 --- a/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql +++ b/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql @@ -5,8 +5,9 @@ * @problem.severity info * @precision high * @id rb/database-query-in-loop - * @tags performance - * quality + * @tags quality + * reliability + * performance */ import ruby diff --git a/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql b/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql index 808ce42dd85d..849fb8ecd5a7 100644 --- a/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql +++ b/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql @@ -5,8 +5,9 @@ * @kind problem * @problem.severity warning * @id rb/useless-assignment-to-local - * @tags maintainability - * quality + * @tags quality + * maintainability + * useless-code * external/cwe/cwe-563 * @precision high */ From 08d28a5b85aa29466a8eaff3f34a97d77fd49de1 Mon Sep 17 00:00:00 2001 From: Michael Nebel Date: Tue, 17 Jun 2025 13:17:27 +0200 Subject: [PATCH 2/2] Ruby: Add change-note. --- ruby/ql/src/change-notes/2025-06-17-tagging.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 ruby/ql/src/change-notes/2025-06-17-tagging.md diff --git a/ruby/ql/src/change-notes/2025-06-17-tagging.md b/ruby/ql/src/change-notes/2025-06-17-tagging.md new file mode 100644 index 000000000000..757e1c55577d --- /dev/null +++ b/ruby/ql/src/change-notes/2025-06-17-tagging.md @@ -0,0 +1,5 @@ +--- +category: queryMetadata +--- +* Update query metadata tags for `rb/database-query-in-loop` and `rb/useless-assignment-to-local` to align with the established +[Query file metadata and alert message style guide](https://github.com/github/codeql/blob/main/docs/query-metadata-style-guide.md#quality-query-sub-category-tags).