From b3225cf7e349837b866afd0e3dc12ab9afa8e28f Mon Sep 17 00:00:00 2001 From: Jeroen Ketema Date: Fri, 4 Jul 2025 15:22:03 +0200 Subject: [PATCH 1/2] Rubt: Fix typo in query message --- ruby/ql/src/experimental/ldap-improper-auth/ImproperLdapAuth.ql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ruby/ql/src/experimental/ldap-improper-auth/ImproperLdapAuth.ql b/ruby/ql/src/experimental/ldap-improper-auth/ImproperLdapAuth.ql index f155f4ae2eca..e82ff1d1e30f 100644 --- a/ruby/ql/src/experimental/ldap-improper-auth/ImproperLdapAuth.ql +++ b/ruby/ql/src/experimental/ldap-improper-auth/ImproperLdapAuth.ql @@ -16,5 +16,5 @@ import ImproperLdapAuthFlow::PathGraph from ImproperLdapAuthFlow::PathNode source, ImproperLdapAuthFlow::PathNode sink where ImproperLdapAuthFlow::flowPath(source, sink) -select sink.getNode(), source, sink, "This LDAP authencation depends on a $@.", source.getNode(), +select sink.getNode(), source, sink, "This LDAP authentication depends on a $@.", source.getNode(), "user-provided value" From 52bbfa30d2e2ee7cfb81f022682c205d6b8b1761 Mon Sep 17 00:00:00 2001 From: Jeroen Ketema Date: Fri, 4 Jul 2025 15:32:07 +0200 Subject: [PATCH 2/2] Ruby: update expected test results --- .../experimental/ImproperLdapAuth/ImproperLdapAuth.expected | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ruby/ql/test/query-tests/experimental/ImproperLdapAuth/ImproperLdapAuth.expected b/ruby/ql/test/query-tests/experimental/ImproperLdapAuth/ImproperLdapAuth.expected index 1b0e8d4fbb38..635cfcd4b3e7 100644 --- a/ruby/ql/test/query-tests/experimental/ImproperLdapAuth/ImproperLdapAuth.expected +++ b/ruby/ql/test/query-tests/experimental/ImproperLdapAuth/ImproperLdapAuth.expected @@ -16,5 +16,5 @@ nodes | ImproperLdapAuth.rb:31:24:31:27 | pass | semmle.label | pass | subpaths #select -| ImproperLdapAuth.rb:15:23:15:26 | pass | ImproperLdapAuth.rb:5:12:5:17 | call to params | ImproperLdapAuth.rb:15:23:15:26 | pass | This LDAP authencation depends on a $@. | ImproperLdapAuth.rb:5:12:5:17 | call to params | user-provided value | -| ImproperLdapAuth.rb:31:24:31:27 | pass | ImproperLdapAuth.rb:24:12:24:17 | call to params | ImproperLdapAuth.rb:31:24:31:27 | pass | This LDAP authencation depends on a $@. | ImproperLdapAuth.rb:24:12:24:17 | call to params | user-provided value | +| ImproperLdapAuth.rb:15:23:15:26 | pass | ImproperLdapAuth.rb:5:12:5:17 | call to params | ImproperLdapAuth.rb:15:23:15:26 | pass | This LDAP authentication depends on a $@. | ImproperLdapAuth.rb:5:12:5:17 | call to params | user-provided value | +| ImproperLdapAuth.rb:31:24:31:27 | pass | ImproperLdapAuth.rb:24:12:24:17 | call to params | ImproperLdapAuth.rb:31:24:31:27 | pass | This LDAP authentication depends on a $@. | ImproperLdapAuth.rb:24:12:24:17 | call to params | user-provided value |