Skip to content

Commit d7d7f4f

Browse files
authored
fix: Hide dock icon only for macOS (#453)
* fix: Hide dock icon & update electron * chore: Rollback to timeout and run only if dock exists (fix Windows)
1 parent 492b639 commit d7d7f4f

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

main.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,15 @@ const browserWindowOpts = {
2626
},
2727
};
2828

29-
const delayedHideAppIcon = () =>
30-
// Setting a timeout because the showDockIcon is not currently working
31-
// See more at https://github.com/maxogden/menubar/issues/306
32-
setTimeout(() => {
33-
app.dock.hide();
34-
}, 1500);
29+
const delayedHideAppIcon = () => {
30+
if (app.dock && app.dock.hide) {
31+
// Setting a timeout because the showDockIcon is not currently working
32+
// See more at https://github.com/maxogden/menubar/issues/306
33+
setTimeout(() => {
34+
app.dock.hide();
35+
}, 1500);
36+
}
37+
};
3538

3639
app.on('ready', async () => {
3740
await onFirstRunMaybe();

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
"@types/react-transition-group": "^4.2.4",
145145
"@types/styled-components": "^5.0.1",
146146
"css-loader": "^5.0.1",
147-
"electron": "^11.0.2",
147+
"electron": "^11.1.0",
148148
"electron-builder": "^22.9.1",
149149
"electron-notarize": "^1.0.0",
150150
"jest": "^26.6.3",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2215,10 +2215,10 @@ electron-updater@^4.3.5:
22152215
lodash.isequal "^4.5.0"
22162216
semver "^7.3.2"
22172217

2218-
electron@^11.0.2:
2219-
version "11.0.2"
2220-
resolved "https://registry.yarnpkg.com/electron/-/electron-11.0.2.tgz#c7bd2b9abdc1446f4578dbfa22573014b6b2df58"
2221-
integrity sha512-FTYtCm0oj8B8EJhp99BQSW2bd40xYEG/txMj+W3Ed0CNu5zVIIXb5WIrhXLvhcasN5LKy9nkmSZ+u220lCaARg==
2218+
electron@^11.1.0:
2219+
version "11.1.0"
2220+
resolved "https://registry.yarnpkg.com/electron/-/electron-11.1.0.tgz#8dfdf579d1eb79feef3e3d2937fc022e72129c90"
2221+
integrity sha512-RFAhR/852VMaRd9NSe7jprwSoG9dLc6u1GwnqRWg+/3cy/8Zrwt1Betw1lXiZH7hGuB9K2cqju83Xv5Pq5ZSGA==
22222222
dependencies:
22232223
"@electron/get" "^1.0.1"
22242224
"@types/node" "^12.0.12"

0 commit comments

Comments
 (0)